Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 2724403005: Add a 1px border stroke to the shelf button active app indicator. (Closed)

Created:
3 years, 9 months ago by Evan Stade
Modified:
3 years, 9 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a 1px border stroke to the shelf button active app indicator. BUG=670970 Review-Url: https://codereview.chromium.org/2724403005 Cr-Commit-Position: refs/heads/master@{#454741} Committed: https://chromium.googlesource.com/chromium/src/+/7367db27e8ba876cd256abe839deda4078a32d9d

Patch Set 1 #

Total comments: 3

Patch Set 2 : adjust color and position #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M ash/common/shelf/shelf_button.cc View 1 2 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Evan Stade
personally I think the stroke is too light, but we can easily change the opacity ...
3 years, 9 months ago (2017-03-03 23:01:03 UTC) #2
Daniel Erat
https://codereview.chromium.org/2724403005/diff/1/ash/common/shelf/shelf_button.cc File ash/common/shelf/shelf_button.cc (right): https://codereview.chromium.org/2724403005/diff/1/ash/common/shelf/shelf_button.cc#newcode149 ash/common/shelf/shelf_button.cc:149: const float dsf = canvas->UndoDeviceScaleFactor(); i don't know much ...
3 years, 9 months ago (2017-03-03 23:15:52 UTC) #5
Evan Stade
https://codereview.chromium.org/2724403005/diff/1/ash/common/shelf/shelf_button.cc File ash/common/shelf/shelf_button.cc (right): https://codereview.chromium.org/2724403005/diff/1/ash/common/shelf/shelf_button.cc#newcode149 ash/common/shelf/shelf_button.cc:149: const float dsf = canvas->UndoDeviceScaleFactor(); On 2017/03/03 23:15:52, Daniel ...
3 years, 9 months ago (2017-03-04 01:02:23 UTC) #12
Daniel Erat
lgtm https://codereview.chromium.org/2724403005/diff/1/ash/common/shelf/shelf_button.cc File ash/common/shelf/shelf_button.cc (right): https://codereview.chromium.org/2724403005/diff/1/ash/common/shelf/shelf_button.cc#newcode149 ash/common/shelf/shelf_button.cc:149: const float dsf = canvas->UndoDeviceScaleFactor(); On 2017/03/04 01:02:22, ...
3 years, 9 months ago (2017-03-04 01:17:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724403005/20001
3 years, 9 months ago (2017-03-04 01:26:34 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 01:31:08 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7367db27e8ba876cd256abe839de...

Powered by Google App Engine
This is Rietveld 408576698