Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2724403002: Disabled tests failing with SwiftShader (Closed)

Created:
3 years, 9 months ago by sugoi1
Modified:
3 years, 9 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabled tests failing with SwiftShader SwiftShader enables WebGL on systems where it was previously disabled, which causes some telemetry tests to timeout. Those tests are disabled here. BUG=698006 Review-Url: https://codereview.chromium.org/2724403002 Cr-Commit-Position: refs/heads/master@{#454379} Committed: https://chromium.googlesource.com/chromium/src/+/f324334b293203e94f5f390c6671b16a6d86dd1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/perf/benchmarks/system_health_smoke_test.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sugoi1
Here's the cl with the 2 tests disabled.
3 years, 9 months ago (2017-03-02 20:13:08 UTC) #2
nednguyen
On 2017/03/02 20:13:08, sugoi1 wrote: > Here's the cl with the 2 tests disabled. Lgtm
3 years, 9 months ago (2017-03-02 20:20:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724403002/1
3 years, 9 months ago (2017-03-02 21:17:15 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 21:24:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f324334b293203e94f5f390c6671...

Powered by Google App Engine
This is Rietveld 408576698