Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 27244: Don't send WebInputEvents from the renderer to the browser.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by Elliot Glaysher
Modified:
5 years, 9 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Don't send WebInputEvents from the renderer to the browser. The browser process now keeps a queue of the last keyboard events that it sent to the renderer in a queue and pops them on ACK. If a key is unhandled, we use the copy in the browser process; we don't even send the key back in the ACK anymore. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10563

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -17 lines) Patch
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host.h View 3 chunks +8 lines, -1 line 2 comments Download
M chrome/browser/renderer_host/render_widget_host.cc View 3 chunks +31 lines, -6 lines 2 comments Download
M chrome/browser/renderer_host/render_widget_host_unittest.cc View 5 chunks +62 lines, -2 lines 0 comments Download
M chrome/renderer/render_widget.cc View 1 chunk +2 lines, -4 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
8 years ago (2009-02-26 23:06:25 UTC) #1
Elliot Glaysher
(Accidentally typed dean when I meant darin.)
8 years ago (2009-02-26 23:44:36 UTC) #2
darin (slow to review)
http://codereview.chromium.org/27244/diff/1/5 File chrome/browser/renderer_host/render_widget_host.h (right): http://codereview.chromium.org/27244/diff/1/5#newcode358 Line 358: std::queue<WebKeyboardEvent> key_queue_; i would have expected this queue ...
8 years ago (2009-02-26 23:58:38 UTC) #3
Elliot Glaysher
http://codereview.chromium.org/27244/diff/1/5 File chrome/browser/renderer_host/render_widget_host.h (right): http://codereview.chromium.org/27244/diff/1/5#newcode358 Line 358: std::queue<WebKeyboardEvent> key_queue_; On 2009/02/26 23:58:38, darin wrote: > ...
8 years ago (2009-02-27 00:06:45 UTC) #4
darin (slow to review)
I agree that this change makes sense on its own. LGTM w/ RAW_KEY_DOWN. I think ...
8 years ago (2009-02-27 00:15:56 UTC) #5
Dean McNamee
Did you comment on the associated bug 4772? On 2009/02/27 00:15:56, darin wrote: > I ...
8 years ago (2009-02-27 11:07:35 UTC) #6
Avi
8 years ago (2009-02-27 15:12:47 UTC) #7
This looks good. I agree that the next step is to turn the queue into native
events, but this works on its own.

http://codereview.chromium.org/27244/diff/1/4
File chrome/browser/renderer_host/render_widget_host.cc (right):

http://codereview.chromium.org/27244/diff/1/4#newcode309
Line 309: if (input_event.type == WebInputEvent::KEY_DOWN ||
On 2009/02/27 00:15:56, darin wrote:
> i think we may also need RAW_KEY_DOWN here, right?

RAW_KEY_DOWN does not yet exist. It will once I nail my final issues and
recommit my patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd