Don't send WebInputEvents from the renderer to the browser....

chrome/browser/renderer_host/render_widget_host.h

Index: chrome/browser/renderer_host/render_widget_host.h
===================================================================
--- chrome/browser/renderer_host/render_widget_host.h	(revision 10502)
+++ chrome/browser/renderer_host/render_widget_host.h	(working copy)
@@ -5,12 +5,14 @@
 #ifndef CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_H_
 #define CHROME_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_H_
 
+#include <queue>
 #include <vector>
 
 #include "base/gfx/size.h"
 #include "base/timer.h"
 #include "chrome/common/ipc_channel.h"
 #include "testing/gtest/include/gtest/gtest_prod.h"
+#include "webkit/glue/webinputevent.h"
 
 namespace gfx {
 class Rect;
@@ -221,7 +223,7 @@
 
   // Called when we an InputEvent was not processed by the renderer. This is
   // overridden by RenderView to send upwards to its delegate.
-  virtual void UnhandledInputEvent(const WebInputEvent& event) {}
+  virtual void UnhandledKeyboardEvent(const WebKeyboardEvent& event) {}
 
   // Notification that the user pressed the enter key or the spacebar. The
   // render view host overrides this to forward the information to its delegate
@@ -350,6 +352,11 @@
   // operation to finish.
   base::TimeTicks repaint_start_time_;
 
+  // A queue of keyboard events. We can't trust data from the renderer so we
+  // stuff key events into a queue and pop them out on ACK, feeding our copy
+  // back to whatever unhandled handler instead of the returned version.
+  std::queue<WebKeyboardEvent> key_queue_;

[darin (slow to review), 2009/02/26 23:58:38]

i would have expected this queue to contain the native platform event from which
we derived a WebKeyboardEvent.  the goal of this CL is to remove the
actual_message field of WebKeyboardEvent, right?

[Elliot Glaysher, 2009/02/27 00:06:45]

The goal was to stop passing a WebKeyboardEvent back across the IPC channel
since we can't trust the renderer. The RWH interface takes Web*Event objects as
input (in the Forward*Event() methods) and returns them as output (through
RenderViewHostDelegate::HandleKeyboardEvent).

+
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHost);
 };