Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: chrome/browser/renderer_host/render_widget_host.h

Issue 27244: Don't send WebInputEvents from the renderer to the browser.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host.h
--- chrome/browser/renderer_host/render_widget_host.h (revision 10502)
+++ chrome/browser/renderer_host/render_widget_host.h (working copy)
@@ -5,12 +5,14 @@
+#include <queue>
#include <vector>
#include "base/gfx/size.h"
#include "base/timer.h"
#include "chrome/common/ipc_channel.h"
#include "testing/gtest/include/gtest/gtest_prod.h"
+#include "webkit/glue/webinputevent.h"
namespace gfx {
class Rect;
@@ -221,7 +223,7 @@
// Called when we an InputEvent was not processed by the renderer. This is
// overridden by RenderView to send upwards to its delegate.
- virtual void UnhandledInputEvent(const WebInputEvent& event) {}
+ virtual void UnhandledKeyboardEvent(const WebKeyboardEvent& event) {}
// Notification that the user pressed the enter key or the spacebar. The
// render view host overrides this to forward the information to its delegate
@@ -350,6 +352,11 @@
// operation to finish.
base::TimeTicks repaint_start_time_;
+ // A queue of keyboard events. We can't trust data from the renderer so we
+ // stuff key events into a queue and pop them out on ACK, feeding our copy
+ // back to whatever unhandled handler instead of the returned version.
+ std::queue<WebKeyboardEvent> key_queue_;
darin (slow to review) 2009/02/26 23:58:38 i would have expected this queue to contain the na
Elliot Glaysher 2009/02/27 00:06:45 The goal was to stop passing a WebKeyboardEvent ba

Powered by Google App Engine
This is Rietveld 408576698