Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 2724373003: DevTools: do not update timeline tree view details if not visible. (Closed)

Created:
3 years, 9 months ago by alph
Modified:
3 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not update timeline tree view details if not visible. BUG=698102 Review-Url: https://codereview.chromium.org/2724373003 Cr-Commit-Position: refs/heads/master@{#454687} Committed: https://chromium.googlesource.com/chromium/src/+/e1d1055a0cdbc0bccd1eb9c4fe396e96c3ddb565

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
alph
3 years, 9 months ago (2017-03-03 02:09:02 UTC) #2
caseq
lgtm, though it would be nice to have a proper fix for performance when the ...
3 years, 9 months ago (2017-03-03 02:28:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724373003/1
3 years, 9 months ago (2017-03-03 18:54:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/394042)
3 years, 9 months ago (2017-03-03 20:29:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724373003/20001
3 years, 9 months ago (2017-03-03 20:49:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/333641)
3 years, 9 months ago (2017-03-03 21:03:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724373003/20001
3 years, 9 months ago (2017-03-03 21:48:53 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 22:07:22 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1d1055a0cdbc0bccd1eb9c4fe39...

Powered by Google App Engine
This is Rietveld 408576698