Tiles On NTP (copy): fetch popular sites icons for 2nd NTP

components/ntp_tiles/most_visited_sites.cc

Index: components/ntp_tiles/most_visited_sites.cc
diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc
index 4f7c845a6919c83aafb82aaa57673ad309fc1ec6..800ccb422c211f7a925e8f4e913de8598cd15a63 100644
--- a/components/ntp_tiles/most_visited_sites.cc
+++ b/components/ntp_tiles/most_visited_sites.cc
@@ -419,6 +419,11 @@ void MostVisitedSites::OnPopularSitesDownloaded(bool success) {
     LOG(WARNING) << "Download of popular sites failed";
     return;
   }
+
+  for (const PopularSites::Site& popular_site : popular_sites_->sites()) {
+    // Ignore callback; these icons will be seen on the *next* NTP.
+    icon_cacher_->StartFetch(popular_site, base::Closure(), base::Closure());

[Marc Treib, 2017/03/03 09:40:44]

IconCacherImpl DCHECKs that the first closure isn't null - looks like this would
trigger that?
Did I miss something?

[fhorschig, 2017/03/03 10:27:21]

Yes, there is a fix for that:
https://codereview.chromium.org/2725293002/

If that isn't fast enough, I can also rollback.

+  }
 }
 
 void MostVisitedSites::OnIconMadeAvailable(const GURL& site_url) {