Tiles On NTP (copy): fetch popular sites icons for 2nd NTP

components/ntp_tiles/most_visited_sites.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_tiles/most_visited_sites.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 401 matching lines @@
     return;
 
   observer_->OnMostVisitedURLsAvailable(current_tiles_);
 }
 
 void MostVisitedSites::OnPopularSitesDownloaded(bool success) {
   if (!success) {
     LOG(WARNING) << "Download of popular sites failed";
     return;
   }
+
+  for (const PopularSites::Site& popular_site : popular_sites_->sites()) {
+    // Ignore callback; these icons will be seen on the *next* NTP.
+    icon_cacher_->StartFetch(popular_site, base::Closure(), base::Closure());

[Marc Treib, 2017/03/03 09:40:44]

IconCacherImpl DCHECKs that the first closure isn't null - looks like this would
trigger that?
Did I miss something?

[fhorschig, 2017/03/03 10:27:21]

Yes, there is a fix for that:
https://codereview.chromium.org/2725293002/

If that isn't fast enough, I can also rollback.

+  }
 }
 
 void MostVisitedSites::OnIconMadeAvailable(const GURL& site_url) {
   observer_->OnIconMadeAvailable(site_url);
 }
 
 void MostVisitedSites::TopSitesLoaded(TopSites* top_sites) {}
 
 void MostVisitedSites::TopSitesChanged(TopSites* top_sites,
                                        ChangeReason change_reason) {
   if (mv_source_ == NTPTileSource::TOP_SITES) {
     // The displayed tiles are invalidated.
     InitiateTopSitesQuery();
   }
 }
 
 }  // namespace ntp_tiles