Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2724303003: Replace homebrew scrollbar in Files app with that of Blink. (Closed)

Created:
3 years, 9 months ago by yamaguchi
Modified:
3 years, 8 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace homebrew scrollbar in Files app with that of Blink. When overlay scrollbar is enabled in Chrome, there is animation to shrink and fade out the scrollbar thumb when inactive. However, scroll bars that aren't composited will not be animated (see Issue 671644). It would make the scroll bar always thick and simply disappear without fading out after inactive. As a workaround, this change makes the 2 boxes have solid background and contain:paint so as to make sure the scrollers are composited. This changelist is basically same as Issue 2554433002, which was revereted once. This changelist also contains a fix for Issue 697057 in addition. BUG=666589, 697057 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : Add docs. Remove test codes. #

Patch Set 3 : Exclude change to fix UI glitch issue. #

Total comments: 1

Patch Set 4 : Remove hack to make scrollbars composited as it's no longer needed. #

Patch Set 5 : Remove debugging code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 3 2 chunks +0 lines, -50 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table.js View 1 2 4 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
yamaguchi
ptal https://codereview.chromium.org/2724303003/diff/40001/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/2724303003/diff/40001/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode132 ui/file_manager/file_manager/foreground/css/file_manager.css:132: /* TODO(yamaguchi): Remove these when crbug.com/671644 is resolved. ...
3 years, 8 months ago (2017-03-28 14:33:50 UTC) #5
fukino
> This changelist is basically same as Issue 2554433002, which was revereted once. If possible, ...
3 years, 8 months ago (2017-03-29 01:41:31 UTC) #8
yamaguchi
3 years, 8 months ago (2017-03-29 03:44:57 UTC) #9
On 2017/03/29 01:41:31, fukino wrote:
> > This changelist is basically same as Issue 2554433002, which was revereted
> once.
> If possible, it would be great if you upload the reland patch as PS1 and add
> additional changes as PS2.
> 
> > This changelist also contains a fix for Issue 697057 in addition.
> Could you do it in a separate CL?
> (It's https://codereview.chromium.org/2745593003/, isn't it?)

Created another Issue using a reland patch to facilitate review.
https://codereview.chromium.org/2782063002
I will drop this changelist.

Powered by Google App Engine
This is Rietveld 408576698