|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by mikecase (-- gone --) Modified:
3 years, 9 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd microdump_stackwalk target to chromium.android builders.
This will allow the testers to symbolize microdump crash logs.
BUG=593106
Review-Url: https://codereview.chromium.org/2724273003
Cr-Commit-Position: refs/heads/master@{#455516}
Committed: https://chromium.googlesource.com/chromium/src/+/37fc2c0e956c32dda663bc7c3e93bdf16779b35d
Patch Set 1 #
Messages
Total messages: 23 (8 generated)
mikecase@chromium.org changed reviewers: + bpastene@chromium.org, martiniss@chromium.org
lgtm I'm not sure if this will break anything. bpastene might be more confident this won't
lgtm
The CQ bit was checked by mikecase@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by mikecase@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Ok, no idea why windows bot keep failing. Theres no way this CL caused it so going to try again.
The CQ bit was checked by mikecase@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1488993456005180, "parent_rev":
"2bc5b5fb3da0c205a025535faff4fb160ca6467a", "commit_rev":
"37fc2c0e956c32dda663bc7c3e93bdf16779b35d"}
Message was sent while issue was closed.
Description was changed from ========== Add microdump_stackwalk target to chromium.android builders. This will allow the testers to symbolize microdump crash logs. BUG=593106 ========== to ========== Add microdump_stackwalk target to chromium.android builders. This will allow the testers to symbolize microdump crash logs. BUG=593106 Review-Url: https://codereview.chromium.org/2724273003 Cr-Commit-Position: refs/heads/master@{#455516} Committed: https://chromium.googlesource.com/chromium/src/+/37fc2c0e956c32dda663bc7c3e93... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/37fc2c0e956c32dda663bc7c3e93...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2734423002/ by mikecase@chromium.org. The reason for reverting is: So, needed to build dump_sym binary as well. Or the step fails. Building microdump_stalkwalker caused the step to run, but not having dump_sym causes it to fail.
Message was sent while issue was closed.
On 2017/03/08 21:25:15, mikecase wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2734423002/ by mailto:mikecase@chromium.org. > > The reason for reverting is: So, needed to build dump_sym binary as well. Or the > step fails. Building microdump_stalkwalker caused the step to run, but not > having dump_sym causes it to fail. Reverting this doesn't seem to bring the bots back. First failure: https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... First build after the revert (still fail): https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We...
Message was sent while issue was closed.
On 2017/03/09 at 04:15:16, wychen wrote: > On 2017/03/08 21:25:15, mikecase wrote: > > A revert of this CL (patchset #1 id:1) has been created in > > https://codereview.chromium.org/2734423002/ by mailto:mikecase@chromium.org. > > > > The reason for reverting is: So, needed to build dump_sym binary as well. Or the > > step fails. Building microdump_stalkwalker caused the step to run, but not > > having dump_sym causes it to fail. > > Reverting this doesn't seem to bring the bots back. > > First failure: > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... > > First build after the revert (still fail): > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... ugh, I guess they don't clean their build directories between runs. I quick work on a fix for this. Know a good solution
Message was sent while issue was closed.
On 2017/03/09 at 04:44:14, mikecase wrote: > On 2017/03/09 at 04:15:16, wychen wrote: > > On 2017/03/08 21:25:15, mikecase wrote: > > > A revert of this CL (patchset #1 id:1) has been created in > > > https://codereview.chromium.org/2734423002/ by mailto:mikecase@chromium.org. > > > > > > The reason for reverting is: So, needed to build dump_sym binary as well. Or the > > > step fails. Building microdump_stalkwalker caused the step to run, but not > > > having dump_sym causes it to fail. > > > > Reverting this doesn't seem to bring the bots back. > > > > First failure: > > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... > > > > First build after the revert (still fail): > > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... > > ugh, I guess they don't clean their build directories between runs. I quick work on a fix for this. Know a good solution Landing a fix that will actually work here. https://chromium-review.googlesource.com/c/451961/
Message was sent while issue was closed.
On 2017/03/09 at 04:55:00, mikecase wrote: > On 2017/03/09 at 04:44:14, mikecase wrote: > > On 2017/03/09 at 04:15:16, wychen wrote: > > > On 2017/03/08 21:25:15, mikecase wrote: > > > > A revert of this CL (patchset #1 id:1) has been created in > > > > https://codereview.chromium.org/2734423002/ by mailto:mikecase@chromium.org. > > > > > > > > The reason for reverting is: So, needed to build dump_sym binary as well. Or the > > > > step fails. Building microdump_stalkwalker caused the step to run, but not > > > > having dump_sym causes it to fail. > > > > > > Reverting this doesn't seem to bring the bots back. > > > > > > First failure: > > > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... > > > > > > First build after the revert (still fail): > > > https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We... > > > > ugh, I guess they don't clean their build directories between runs. I quick work on a fix for this. Know a good solution > > Landing a fix that will actually work here. > > https://chromium-review.googlesource.com/c/451961/ Bot is green. Should be fixed now |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
