Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2724273003: Add microdump_stackwalk target to chromium.android builders. (Closed)

Created:
3 years, 9 months ago by mikecase (-- gone --)
Modified:
3 years, 9 months ago
Reviewers:
bpastene, martiniss
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add microdump_stackwalk target to chromium.android builders. This will allow the testers to symbolize microdump crash logs. BUG=593106 Review-Url: https://codereview.chromium.org/2724273003 Cr-Commit-Position: refs/heads/master@{#455516} Committed: https://chromium.googlesource.com/chromium/src/+/37fc2c0e956c32dda663bc7c3e93bdf16779b35d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M testing/buildbot/chromium.android.json View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
mikecase (-- gone --)
3 years, 9 months ago (2017-03-02 22:19:46 UTC) #2
martiniss
lgtm I'm not sure if this will break anything. bpastene might be more confident this ...
3 years, 9 months ago (2017-03-02 22:58:07 UTC) #3
bpastene
lgtm
3 years, 9 months ago (2017-03-03 19:30:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724273003/1
3 years, 9 months ago (2017-03-07 00:18:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/378867)
3 years, 9 months ago (2017-03-07 01:46:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724273003/1
3 years, 9 months ago (2017-03-07 23:40:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/396627)
3 years, 9 months ago (2017-03-08 02:34:04 UTC) #12
mikecase (-- gone --)
Ok, no idea why windows bot keep failing. Theres no way this CL caused it ...
3 years, 9 months ago (2017-03-08 17:17:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724273003/1
3 years, 9 months ago (2017-03-08 17:18:02 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/37fc2c0e956c32dda663bc7c3e93bdf16779b35d
3 years, 9 months ago (2017-03-08 19:40:03 UTC) #18
mikecase (-- gone --)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2734423002/ by mikecase@chromium.org. ...
3 years, 9 months ago (2017-03-08 21:25:15 UTC) #19
wychen
On 2017/03/08 21:25:15, mikecase wrote: > A revert of this CL (patchset #1 id:1) has ...
3 years, 9 months ago (2017-03-09 04:15:16 UTC) #20
mikecase (-- gone --)
On 2017/03/09 at 04:15:16, wychen wrote: > On 2017/03/08 21:25:15, mikecase wrote: > > A ...
3 years, 9 months ago (2017-03-09 04:44:14 UTC) #21
mikecase (-- gone --)
On 2017/03/09 at 04:44:14, mikecase wrote: > On 2017/03/09 at 04:15:16, wychen wrote: > > ...
3 years, 9 months ago (2017-03-09 04:55:00 UTC) #22
mikecase (-- gone --)
3 years, 9 months ago (2017-03-09 06:37:23 UTC) #23
Message was sent while issue was closed.
On 2017/03/09 at 04:55:00, mikecase wrote:
> On 2017/03/09 at 04:44:14, mikecase wrote:
> > On 2017/03/09 at 04:15:16, wychen wrote:
> > > On 2017/03/08 21:25:15, mikecase wrote:
> > > > A revert of this CL (patchset #1 id:1) has been created in
> > > > https://codereview.chromium.org/2734423002/ by
mailto:mikecase@chromium.org.
> > > > 
> > > > The reason for reverting is: So, needed to build dump_sym binary as
well. Or the
> > > > step fails. Building microdump_stalkwalker caused the step to run, but
not
> > > > having dump_sym causes it to fail.
> > > 
> > > Reverting this doesn't seem to bring the bots back.
> > > 
> > > First failure:
> > >
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We...
> > > 
> > > First build after the revert (still fail):
> > >
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20We...
> > 
> > ugh, I guess they don't clean their build directories between runs. I quick
work on a fix for this. Know a good solution
> 
> Landing a fix that will actually work here.
> 
> https://chromium-review.googlesource.com/c/451961/

Bot is green. Should be fixed now

Powered by Google App Engine
This is Rietveld 408576698