ash: Use enum for SessionController::CycleActiveUser

ash: Use enum for SessionController::CycleActiveUser

- Move SessionStateDelegate::CycleUser to session_types.h
  as ash::CycleUserDirection;
- Use enum for SessionController::CycleActiveUser and map it
  to ash::CycleUserDirection;

BUG=648964
Review-Url: https://codereview.chromium.org/2724163002
Cr-Commit-Position: refs/heads/master@{#454414}
Committed: https://chromium.googlesource.com/chromium/src/+/8f48ad0c7eda17f66bbc4a983f0412dc0f103ab1

[xiyuan, 2017-03-01 23:29:37]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 23:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-03-01 23:31:46]

xiyuan@chromium.org changed reviewers:
+ jamescook@chromium.org, tsepez@chromium.org

[xiyuan, 2017-03-01 23:31:46]

jamescook@,
  please drive the review.

tsepez@, 
  session_controller.mojom and typemapping

Thanks.

[Tom Sepez, 2017-03-02 00:05:36]

lgtm

[James Cook, 2017-03-02 00:13:34]

LGTM with a naming suggestion

https://codereview.chromium.org/2724163002/diff/1/ash/public/cpp/session_types.h
File ash/public/cpp/session_types.h (right):

https://codereview.chromium.org/2724163002/diff/1/ash/public/cpp/session_type...
ash/public/cpp/session_types.h:27: enum class CycleUser {
I think this would be clearer as:

enum class CycleUserDirection {
  NEXT,
  PREVIOUS,
}

or something that has "direction" in it.

Then all the params/local variables could be called "direction".

[commit-bot: I haz the power, 2017-03-02 00:16:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:16:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-03-02 21:27:38]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[xiyuan, 2017-03-02 21:27:45]

https://codereview.chromium.org/2724163002/diff/1/ash/public/cpp/session_types.h
File ash/public/cpp/session_types.h (right):

https://codereview.chromium.org/2724163002/diff/1/ash/public/cpp/session_type...
ash/public/cpp/session_types.h:27: enum class CycleUser {
On 2017/03/02 00:13:34, James Cook wrote:
> I think this would be clearer as:
> 
> enum class CycleUserDirection {
>   NEXT,
>   PREVIOUS,
> }
> 
> or something that has "direction" in it.
> 
> Then all the params/local variables could be called "direction".

Done.

[commit-bot: I haz the power, 2017-03-02 21:28:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 21:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 21:54:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xiyuan, 2017-03-02 21:59:23]

The CQ bit was checked by xiyuan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 22:00:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2017-03-02 22:03:02]

Description was changed from

==========
ash: Use enum for SessionController::CycleActiveUser

- Move SessionStateDelegate::CycleUser to session_types.h
  as ash::CycleUser;
- Use enum for SessionController::CycleActiveUser and map it
  to ash::CycleUser;

BUG=648964
==========

to

==========
ash: Use enum for SessionController::CycleActiveUser

- Move SessionStateDelegate::CycleUser to session_types.h
  as ash::CycleUserDirection;
- Use enum for SessionController::CycleActiveUser and map it
  to ash::CycleUserDirection;

BUG=648964
==========

[commit-bot: I haz the power, 2017-03-02 22:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 22:33:05]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-03-02 22:37:27]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2017-03-02 22:37:27]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2724163002/#ps40001
(title: "fix ash_shell_with_content compile")

[commit-bot: I haz the power, 2017-03-02 22:38:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 22:44:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488494247240280,
"parent_rev": "e7a058aa7db4c0fc172200fd16c800ec1b94d8e6", "commit_rev":
"8f48ad0c7eda17f66bbc4a983f0412dc0f103ab1"}

[commit-bot: I haz the power, 2017-03-02 22:45:19]

Description was changed from

==========
ash: Use enum for SessionController::CycleActiveUser

- Move SessionStateDelegate::CycleUser to session_types.h
  as ash::CycleUserDirection;
- Use enum for SessionController::CycleActiveUser and map it
  to ash::CycleUserDirection;

BUG=648964
==========

to

==========
ash: Use enum for SessionController::CycleActiveUser

- Move SessionStateDelegate::CycleUser to session_types.h
  as ash::CycleUserDirection;
- Use enum for SessionController::CycleActiveUser and map it
  to ash::CycleUserDirection;

BUG=648964

Review-Url: https://codereview.chromium.org/2724163002
Cr-Commit-Position: refs/heads/master@{#454414}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f48ad0c7eda17f66bbc4a983f04...
==========

[commit-bot: I haz the power, 2017-03-02 22:45:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f48ad0c7eda17f66bbc4a983f04...