Android: Add missing resources to android studio

Android: Add missing resources to android studio

Some apk targets directly depend on their resources (e.g.
//android_webview/test:android_webview_apk). These are not picked up by
javac and need to be added to gradle in order to allow editing of all
resources.

BUG=682846
Review-Url: https://codereview.chromium.org/2724093003
Cr-Commit-Position: refs/heads/master@{#456416}
Committed: https://chromium.googlesource.com/chromium/src/+/f37993e1a795b3d8d72bb858a8ccb0a74b82400b

[Peter Wen, 2017-03-01 20:26:52]

Description was changed from

==========
Android: Add missing resources to android studio

Some apk targets directly depend on their resources (e.g.
//android_webview/test:android_webview_apk). These are not picked up by
javac and need to be added to gradle in order to allow editing of all
resources.

BUG=682846
==========

to

==========
Android: Add missing resources to android studio

Some apk targets directly depend on their resources (e.g.
//android_webview/test:android_webview_apk). These are not picked up by
javac and need to be added to gradle in order to allow editing of all
resources.

Also set third_party/junit to be treated as a prebuilt for android
studio as android_library plugins do not have those java libraries.

BUG=682846
==========

[Peter Wen, 2017-03-01 20:27:36]

wnwen@chromium.org changed reviewers:
+ estevenson@chromium.org

[Peter Wen, 2017-03-01 20:27:37]

A couple more resources that the original CL doesn't include.

[estevenson, 2017-03-01 20:44:00]

On 2017/03/01 20:27:37, Peter Wen wrote:
> A couple more resources that the original CL doesn't include.

lgtm

[Peter Wen, 2017-03-01 20:57:09]

wnwen@chromium.org changed reviewers:
+ mikecase@chromium.org

[Peter Wen, 2017-03-01 20:57:09]

+mikecase@ for OWNERS build/android and third_party/junit

[Peter Wen, 2017-03-07 17:47:56]

Friendly ping. :)

[Peter Wen, 2017-03-13 14:45:59]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-03-13 14:45:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
estevenson@chromium.org
Link to the patchset: https://codereview.chromium.org/2724093003/#ps20001
(title: "Moving third_party changes to separate CL.")

[commit-bot: I haz the power, 2017-03-13 14:46:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 14:55:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:55:14]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Wen, 2017-03-13 15:02:49]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org
- mikecase@chromium.org

[Peter Wen, 2017-03-13 15:02:49]

-mikecase@ split to other CL: http://crrev.com/2750593002

+agrieve@ for build/ OWNERS

[agrieve, 2017-03-13 16:45:24]

On 2017/03/13 15:02:49, Peter Wen wrote:
> -mikecase@ split to other CL: http://crrev.com/2750593002
> 
> +agrieve@ for build/ OWNERS

lgtm

[Peter Wen, 2017-03-13 16:57:30]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2017-03-13 16:57:44]

Description was changed from

==========
Android: Add missing resources to android studio

Some apk targets directly depend on their resources (e.g.
//android_webview/test:android_webview_apk). These are not picked up by
javac and need to be added to gradle in order to allow editing of all
resources.

Also set third_party/junit to be treated as a prebuilt for android
studio as android_library plugins do not have those java libraries.

BUG=682846
==========

to

==========
Android: Add missing resources to android studio

Some apk targets directly depend on their resources (e.g.
//android_webview/test:android_webview_apk). These are not picked up by
javac and need to be added to gradle in order to allow editing of all
resources.

BUG=682846
==========

[commit-bot: I haz the power, 2017-03-13 16:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 17:36:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489424250216160,
"parent_rev": "d29465d6b7e9cae2effb709bfb0c924db8b4b885", "commit_rev":
"f37993e1a795b3d8d72bb858a8ccb0a74b82400b"}

[commit-bot: I haz the power, 2017-03-13 17:37:05]

Description was changed from

==========
Android: Add missing resources to android studio

Some apk targets directly depend on their resources (e.g.
//android_webview/test:android_webview_apk). These are not picked up by
javac and need to be added to gradle in order to allow editing of all
resources.

BUG=682846
==========

to

==========
Android: Add missing resources to android studio

Some apk targets directly depend on their resources (e.g.
//android_webview/test:android_webview_apk). These are not picked up by
javac and need to be added to gradle in order to allow editing of all
resources.

BUG=682846

Review-Url: https://codereview.chromium.org/2724093003
Cr-Commit-Position: refs/heads/master@{#456416}
Committed:
https://chromium.googlesource.com/chromium/src/+/f37993e1a795b3d8d72bb858a8cc...
==========

[commit-bot: I haz the power, 2017-03-13 17:37:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f37993e1a795b3d8d72bb858a8cc...