Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 2724073002: Un-deprecated DisablePrintPreview policy. (Closed)

Created:
3 years, 9 months ago by Georges Khalil
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang, pastarmovj
CC:
chromium-reviews, tnagel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Un-deprecated DisablePrintPreview policy. See crbug.com/374321 for history on why DisablePrintPreview was disabled. The functionality as well as the command line where never removed. This CL reinstates that policy, as it's a demand from enterprise users. BUG=691671, 374321 Review-Url: https://codereview.chromium.org/2724073002 Cr-Commit-Position: refs/heads/master@{#458438} Committed: https://chromium.googlesource.com/chromium/src/+/cc65a6c44dc84e130f0d3f01e41d92afc93fb229

Patch Set 1 : Un-deprecated DisablePrintPreview policy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/policy/resources/policy_templates.json View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Georges Khalil
Julian, PTAL.
3 years, 9 months ago (2017-03-01 18:48:53 UTC) #6
pastarmovj
Since Lei is owner of the affected service I think he should give us his ...
3 years, 9 months ago (2017-03-02 06:30:48 UTC) #8
Georges Khalil
On 2017/03/02 06:30:48, pastarmovj wrote: > Since Lei is owner of the affected service I ...
3 years, 9 months ago (2017-03-02 13:50:56 UTC) #9
Georges Khalil
On 2017/03/02 13:50:56, Georges Khalil wrote: > On 2017/03/02 06:30:48, pastarmovj wrote: > > Since ...
3 years, 9 months ago (2017-03-14 20:15:29 UTC) #10
Lei Zhang
On 2017/03/02 06:30:48, pastarmovj wrote: > Since Lei is owner of the affected service I ...
3 years, 9 months ago (2017-03-14 20:40:36 UTC) #11
Georges Khalil
On 2017/03/14 20:40:36, Lei Zhang (super slow) wrote: > On 2017/03/02 06:30:48, pastarmovj wrote: > ...
3 years, 9 months ago (2017-03-14 20:41:50 UTC) #12
pastarmovj
lgtm
3 years, 9 months ago (2017-03-15 06:49:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724073002/30001
3 years, 9 months ago (2017-03-21 15:55:45 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 16:48:52 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:30001) as
https://chromium.googlesource.com/chromium/src/+/cc65a6c44dc84e130f0d3f01e41d...

Powered by Google App Engine
This is Rietveld 408576698