|
|
Chromium Code Reviews|
Created:
3 years, 9 months ago by Georges Khalil Modified:
3 years, 9 months ago CC:
chromium-reviews, tnagel+watch_chromium.org, asvitkine+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUn-deprecated DisablePrintPreview policy.
See crbug.com/374321 for history on why DisablePrintPreview was disabled. The functionality as well as the command line where never removed.
This CL reinstates that policy, as it's a demand from enterprise users.
BUG=691671, 374321
Review-Url: https://codereview.chromium.org/2724073002
Cr-Commit-Position: refs/heads/master@{#458438}
Committed: https://chromium.googlesource.com/chromium/src/+/cc65a6c44dc84e130f0d3f01e41d92afc93fb229
Patch Set 1 : Un-deprecated DisablePrintPreview policy. #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Un-deprecated DisablePrintPreview policy. BUG=691671 ========== to ========== Un-deprecated DisablePrintPreview policy. See crbug.com/374321 for history on why DisablePrintPreview was disabled. The functionality as well as the command line where never removed. This CL reinstates that policy, as it's a demande from enterprise users. BUG=691671,374321 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:2) has been deleted
Description was changed from ========== Un-deprecated DisablePrintPreview policy. See crbug.com/374321 for history on why DisablePrintPreview was disabled. The functionality as well as the command line where never removed. This CL reinstates that policy, as it's a demande from enterprise users. BUG=691671,374321 ========== to ========== Un-deprecated DisablePrintPreview policy. See crbug.com/374321 for history on why DisablePrintPreview was disabled. The functionality as well as the command line where never removed. This CL reinstates that policy, as it's a demand from enterprise users. BUG=691671,374321 ==========
georgesak@chromium.org changed reviewers: + pastarmovj@chromium.org
Julian, PTAL.
pastarmovj@chromium.org changed reviewers: + thestig@chromium.org
Since Lei is owner of the affected service I think he should give us his blessing about this and/or explain why is this policy deprecated.
On 2017/03/02 06:30:48, pastarmovj wrote: > Since Lei is owner of the affected service I think he should give us his > blessing about this and/or explain why is this policy deprecated. Thanks Julian. Lei, PTAL.
On 2017/03/02 13:50:56, Georges Khalil wrote: > On 2017/03/02 06:30:48, pastarmovj wrote: > > Since Lei is owner of the affected service I think he should give us his > > blessing about this and/or explain why is this policy deprecated. > > Thanks Julian. > > Lei, PTAL. Friendly ping.
On 2017/03/02 06:30:48, pastarmovj wrote: > Since Lei is owner of the affected service I think he should give us his > blessing about this and/or explain why is this policy deprecated. LGTM We can try deprecating again some day when print preview actually meets all of our users' needs. Such that they won't have to fall back to the system print dialog.
On 2017/03/14 20:40:36, Lei Zhang (super slow) wrote: > On 2017/03/02 06:30:48, pastarmovj wrote: > > Since Lei is owner of the affected service I think he should give us his > > blessing about this and/or explain why is this policy deprecated. > > LGTM > > We can try deprecating again some day when print preview actually meets all of > our users' needs. Such that they won't have to fall back to the system print > dialog. SGTM. Julian, I need your owner's stamp, thanks!
lgtm
The CQ bit was checked by georgesak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 30001, "attempt_start_ts": 1490111724602640,
"parent_rev": "b6b96c3de7c6db78762ce660b274514bd18a1c0b", "commit_rev":
"cc65a6c44dc84e130f0d3f01e41d92afc93fb229"}
Message was sent while issue was closed.
Description was changed from ========== Un-deprecated DisablePrintPreview policy. See crbug.com/374321 for history on why DisablePrintPreview was disabled. The functionality as well as the command line where never removed. This CL reinstates that policy, as it's a demand from enterprise users. BUG=691671,374321 ========== to ========== Un-deprecated DisablePrintPreview policy. See crbug.com/374321 for history on why DisablePrintPreview was disabled. The functionality as well as the command line where never removed. This CL reinstates that policy, as it's a demand from enterprise users. BUG=691671,374321 Review-Url: https://codereview.chromium.org/2724073002 Cr-Commit-Position: refs/heads/master@{#458438} Committed: https://chromium.googlesource.com/chromium/src/+/cc65a6c44dc84e130f0d3f01e41d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:30001) as https://chromium.googlesource.com/chromium/src/+/cc65a6c44dc84e130f0d3f01e41d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
