Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2724013002: net: remove CryptoModule class (Closed)

Created:
3 years, 9 months ago by tfarina
Modified:
3 years, 9 months ago
Reviewers:
armansito, mattm, Dan Beam, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, cbentzel+watch_chromium.org, michaelpg+watch-options_chromium.org, michaelpg+watch-md-settings_chromium.org, stevenjb+watch_chromium.org, net-reviews_chromium.org, bnc+watch_chromium.org, oshima+watch_chromium.org, tfarina, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, eroman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

net: remove CryptoModule class After recent refactoring fixing TODOs in NSSCertDatabase, this abstraction became unused in Chromium and thus can be removed now. BUG=488586 TEST=net_unittests R=mattm@chromium.org Review-Url: https://codereview.chromium.org/2724013002 Cr-Commit-Position: refs/heads/master@{#454561} Committed: https://chromium.googlesource.com/chromium/src/+/b170db900b0481ee3e700de4b54332ebcb758af0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -122 lines) Patch
M chrome/browser/certificate_manager_model.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_nss.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/crypto_module_password_dialog_nss.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/certificates_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_certificate_importer_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
D net/base/crypto_module.h View 1 chunk +0 lines, -51 lines 0 comments Download
D net/base/crypto_module_nss.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D net/base/crypto_module_openssl.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M net/cert/nss_cert_database.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/nss_cert_database_chromeos.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/nss_cert_database_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
tfarina
3 years, 9 months ago (2017-03-01 12:16:59 UTC) #3
mattm
lgtm, thanks!
3 years, 9 months ago (2017-03-02 00:33:06 UTC) #6
tfarina
+Scott for chrome OWNER, Dan for chrome/browser/ui/webui/options/ and armansito for chromeos.
3 years, 9 months ago (2017-03-02 10:41:51 UTC) #8
sky
LGTM
3 years, 9 months ago (2017-03-02 18:20:26 UTC) #9
Dan Beam
lgtm
3 years, 9 months ago (2017-03-03 03:10:52 UTC) #10
armansito
chromeos lgtm
3 years, 9 months ago (2017-03-03 05:00:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724013002/1
3 years, 9 months ago (2017-03-03 09:33:35 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 10:59:38 UTC) #16
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b170db900b0481ee3e700de4b543...

Powered by Google App Engine
This is Rietveld 408576698