[sync] skeleton implementation of TypedURLSyncBridge

components/history/core/browser/history_backend.h

Index: components/history/core/browser/history_backend.h
diff --git a/components/history/core/browser/history_backend.h b/components/history/core/browser/history_backend.h
index 2a62a79deccf02c0276c3ab2b043e86708491a9f..c69fde8bff21beea5495c511008da158d2e44d93 100644
--- a/components/history/core/browser/history_backend.h
+++ b/components/history/core/browser/history_backend.h
@@ -53,6 +53,7 @@ struct HistoryDatabaseParams;
 class HistoryDBTask;
 class InMemoryHistoryBackend;
 class TypedUrlSyncableService;
+class TypedURLSyncBridge;
 class HistoryBackendHelper;
 class URLDatabase;
 
@@ -395,6 +396,10 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
   // is owned by |this| object.
   virtual TypedUrlSyncableService* GetTypedUrlSyncableService() const;
 
+  // Returns the sync bridge for syncing typed urls. The returned service
+  // is owned by |this| object.
+  TypedURLSyncBridge* GetTypedURLSyncBridge() const;

[skym, 2017/03/03 17:41:09]

Why is GetTypedUrlSyncableService() virtual and this one not? Are we going to
have to slap virtual on this to make unit tests work?

[Gang Wu, 2017/03/06 08:21:24]

I am not going to add unittest in this CL, so did not add virtual in this CL. I
will add virtual when unittest needed.

+
   // Deleting ------------------------------------------------------------------
 
   virtual void DeleteURLs(const std::vector<GURL>& urls);
@@ -886,10 +891,12 @@ class HistoryBackend : public base::RefCountedThreadSafe<HistoryBackend>,
   // List of observers
   base::ObserverList<HistoryBackendObserver> observers_;
 
-  // Used to manage syncing of the typed urls datatype. This will be null before
-  // Init is called. Defined after observers_ because it unregisters itself as
-  // observer during destruction.
+  // Used to manage syncing of the typed urls datatype. They will be null before
+  // Init is called, and only one will be instantiated after Init is called
+  // depending on switches::kSyncUSSAutocomplete. Defined after observers_

[skym, 2017/03/03 17:41:09]

autocomplete?

[Gang Wu, 2017/03/06 08:21:24]

Done.

+  // because it unregisters itself as observer during destruction.
   std::unique_ptr<TypedUrlSyncableService> typed_url_syncable_service_;
+  std::unique_ptr<TypedURLSyncBridge> typed_url_sync_bridge_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
 };