[sync] skeleton implementation of TypedURLSyncBridge

components/history/core/browser/history_backend.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_
 #define COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 35 matching lines @@
 struct DownloadRow;
 class HistoryBackendClient;
 class HistoryBackendDBBaseTest;
 class HistoryBackendObserver;
 class HistoryBackendTest;
 class HistoryDatabase;
 struct HistoryDatabaseParams;
 class HistoryDBTask;
 class InMemoryHistoryBackend;
 class TypedUrlSyncableService;
+class TypedURLSyncBridge;
 class HistoryBackendHelper;
 class URLDatabase;
 
 // The maximum number of icons URLs per page which can be stored in the
 // thumbnail database.
 static const size_t kMaxFaviconsPerPage = 8;
 
 // The maximum number of bitmaps for a single icon URL which can be stored in
 // the thumbnail database.
 static const size_t kMaxFaviconBitmapsPerIconURL = 8;
@@ skipping 322 matching lines @@
   // If there is no entry in the map for a given visit, that means the visit
   // was SOURCE_BROWSED. Returns false if there is no HistoryDatabase..
   bool GetVisitsSource(const VisitVector& visits, VisitSourceMap* sources);
 
   virtual bool GetURL(const GURL& url, URLRow* url_row);
 
   // Returns the syncable service for syncing typed urls. The returned service
   // is owned by |this| object.
   virtual TypedUrlSyncableService* GetTypedUrlSyncableService() const;
 
+  // Returns the sync bridge for syncing typed urls. The returned service
+  // is owned by |this| object.
+  TypedURLSyncBridge* GetTypedURLSyncBridge() const;

[skym, 2017/03/03 17:41:09]

Why is GetTypedUrlSyncableService() virtual and this one not? Are we going to
have to slap virtual on this to make unit tests work?

[Gang Wu, 2017/03/06 08:21:24]

I am not going to add unittest in this CL, so did not add virtual in this CL. I
will add virtual when unittest needed.

+
   // Deleting ------------------------------------------------------------------
 
   virtual void DeleteURLs(const std::vector<GURL>& urls);
 
   virtual void DeleteURL(const GURL& url);
 
   // Calls ExpireHistoryBackend::ExpireHistoryBetween and commits the change.
   void ExpireHistoryBetween(const std::set<GURL>& restrict_urls,
                             base::Time begin_time,
                             base::Time end_time);
@@ skipping 471 matching lines @@
   // when a catastrophic error occurs.
   std::string db_diagnostics_;
 
   // Map from host to index in the TopHosts list. It is updated only by
   // TopHosts(), so it's usually stale.
   mutable base::hash_map<std::string, int> host_ranks_;
 
   // List of observers
   base::ObserverList<HistoryBackendObserver> observers_;
 
-  // Used to manage syncing of the typed urls datatype. This will be null before
-  // Init is called. Defined after observers_ because it unregisters itself as
-  // observer during destruction.
+  // Used to manage syncing of the typed urls datatype. They will be null before
+  // Init is called, and only one will be instantiated after Init is called
+  // depending on switches::kSyncUSSAutocomplete. Defined after observers_

[skym, 2017/03/03 17:41:09]

autocomplete?

[Gang Wu, 2017/03/06 08:21:24]

Done.

+  // because it unregisters itself as observer during destruction.
   std::unique_ptr<TypedUrlSyncableService> typed_url_syncable_service_;
+  std::unique_ptr<TypedURLSyncBridge> typed_url_sync_bridge_;
 
   DISALLOW_COPY_AND_ASSIGN(HistoryBackend);
 };
 
 }  // namespace history
 
 #endif  // COMPONENTS_HISTORY_CORE_BROWSER_HISTORY_BACKEND_H_