Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2723933003: Rollfowrad of crrev.com/2720863003/: Make --headless flag work on Mac (Closed)

Created:
3 years, 9 months ago by dvallet
Modified:
3 years, 9 months ago
Reviewers:
sky, Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rollfowrad of crrev.com/2720863003/: Make --headless flag work on Mac Fix added child dependency in headless_lib This is pending on splitting headless library so it can be property build in windows. BUG=687407 Review-Url: https://codereview.chromium.org/2723933003 Cr-Commit-Position: refs/heads/master@{#454074} Committed: https://chromium.googlesource.com/chromium/src/+/42a29e0ca43402988b63335e0d53a04f1fe2e61e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_main.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M headless/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/headless_content_browser_client.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dvallet
sky@chromium.org: Please review changes in headless/ skyostil@chromium.org: Please review changes in chrome/
3 years, 9 months ago (2017-03-01 10:29:42 UTC) #6
Sami
lgtm.
3 years, 9 months ago (2017-03-01 11:04:08 UTC) #7
sky
LGTM
3 years, 9 months ago (2017-03-01 20:27:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723933003/1
3 years, 9 months ago (2017-03-01 22:28:15 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 22:35:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42a29e0ca43402988b63335e0d53...

Powered by Google App Engine
This is Rietveld 408576698