Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2723923002: Yukari: organize platform/loader/testing (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
Reviewers:
kinuko, kouhei (in TOK)
CC:
chromium-reviews, Yoav Weiss, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, kouhei (in TOK)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Yukari: organize platform/loader/testing Now platform/loader has a testing directory that contains all files that are built as a part of the platform test_support library. Helper functions in the directory should be available in both blink platform_unittests and webkit_unit_tests. BUG=655916 Review-Url: https://codereview.chromium.org/2723923002 Cr-Commit-Position: refs/heads/master@{#453849} Committed: https://chromium.googlesource.com/chromium/src/+/77e7b6ab3cce4efe1c1114920de1c7a951fe2552

Patch Set 1 #

Patch Set 2 : add missed files #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -198 lines) Patch
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/FontResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/platform/loader/Directories.md View 1 chunk +14 lines, -0 lines 1 comment Download
M third_party/WebKit/Source/platform/loader/fetch/MemoryCacheCorrectnessTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/MemoryCacheTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/loader/fetch/MockResource.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/platform/loader/fetch/MockResource.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/platform/loader/fetch/MockResourceClient.h View 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/WebKit/Source/platform/loader/fetch/MockResourceClient.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/testing/MockResource.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/testing/MockResource.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/loader/testing/MockResourceClient.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/loader/testing/MockResourceClient.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Takashi Toyoshima
ptal
3 years, 9 months ago (2017-03-01 01:50:10 UTC) #3
kouhei (in TOK)
lgtm https://codereview.chromium.org/2723923002/diff/20001/third_party/WebKit/Source/platform/loader/Directories.md File third_party/WebKit/Source/platform/loader/Directories.md (right): https://codereview.chromium.org/2723923002/diff/20001/third_party/WebKit/Source/platform/loader/Directories.md#newcode1 third_party/WebKit/Source/platform/loader/Directories.md:1: # platform/loader directories Having this doc is great!!! ...
3 years, 9 months ago (2017-03-01 01:54:50 UTC) #5
kinuko
lgtm!!
3 years, 9 months ago (2017-03-01 03:18:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723923002/20001
3 years, 9 months ago (2017-03-01 03:40:24 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 05:15:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77e7b6ab3cce4efe1c1114920de1...

Powered by Google App Engine
This is Rietveld 408576698