Relax text validation in FrameSelection::selectWordAroundPosition

Relax text validation in FrameSelection::selectWordAroundPosition

This CL fixes text select failure in the cases that |startOfWord|
 returns VisiblePosition before space like " bar".
In that case, selectWordAroundPosition failed.

This CL covers the case to check text contains characters rather than
 separators.

The root cause is that though |previousBoundary| in |startOfWord| finds 
correct position of " |bar", |mostBackWordPosition| of canonicalization
 moves to "| bar". We can fix it changing function signature from 
 VisiblePosition to Position. However it changes editing code widely.
I think that is a kind of refactoring, but that is massive change. I will
 do it after branch-cut.




BUG=658765
TEST=webkit_unit_test --gtest_filter=FrameSelectionTest.SelectWordAroundPosition2, by hand with https://jsfiddle.net/fpt03tv5/1/

Review-Url: https://codereview.chromium.org/2723913002
Cr-Commit-Position: refs/heads/master@{#453860}
Committed: https://chromium.googlesource.com/chromium/src/+/8b8542139c3680bd68c6fa07b3df6cfd8706b3c9

[yoichio, 2017-03-01 02:02:31]

Description was changed from

==========
[WIP] TTS

BUG=658765
==========

to

==========
[WIP] TTS

patch #1 TTS succeeds with https://jsfiddle.net/fpt03tv5/ 

BUG=658765
==========

[yoichio, 2017-03-01 02:27:56]

Description was changed from

==========
[WIP] TTS

patch #1 TTS succeeds with https://jsfiddle.net/fpt03tv5/ 

BUG=658765
==========

to

==========
Relax text validation in FrameSelection::selectWordAroundPosition

This CL fixes text select failure in the cases that |startOfWord|
 returns VisiblePosition before space like " bar".
In that case, selectWordAroundPosition failed.

This CL covers the case to check text contains characters rather than
 separators.

The root cause is that though |previousBoundary| in |startOfWord| finds 
correct position of " |bar", |mostBackWordPosition| of canonicalization
 moves to " |bar". We can fix it changing function signature from 
 VisiblePosition to Position. However it changes editing code widely.
I think that is a kind of refactoring, but that is massive change. I will
 do it after branch-cut.




BUG=658765
TEST=webkit_unit_test
--gtest_filter=FrameSelectionTest.SelectWordAroundPosition2, by hand with
https://jsfiddle.net/fpt03tv5/1/
==========

[yoichio, 2017-03-01 02:27:57]

yoichio@chromium.org changed reviewers:
+ donnd@chromium.org, yosin@chromium.org

[yoichio, 2017-03-01 02:28:17]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 02:28:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-01 02:29:44]

Description was changed from

==========
Relax text validation in FrameSelection::selectWordAroundPosition

This CL fixes text select failure in the cases that |startOfWord|
 returns VisiblePosition before space like " bar".
In that case, selectWordAroundPosition failed.

This CL covers the case to check text contains characters rather than
 separators.

The root cause is that though |previousBoundary| in |startOfWord| finds 
correct position of " |bar", |mostBackWordPosition| of canonicalization
 moves to " |bar". We can fix it changing function signature from 
 VisiblePosition to Position. However it changes editing code widely.
I think that is a kind of refactoring, but that is massive change. I will
 do it after branch-cut.




BUG=658765
TEST=webkit_unit_test
--gtest_filter=FrameSelectionTest.SelectWordAroundPosition2, by hand with
https://jsfiddle.net/fpt03tv5/1/
==========

to

==========
Relax text validation in FrameSelection::selectWordAroundPosition

This CL fixes text select failure in the cases that |startOfWord|
 returns VisiblePosition before space like " bar".
In that case, selectWordAroundPosition failed.

This CL covers the case to check text contains characters rather than
 separators.

The root cause is that though |previousBoundary| in |startOfWord| finds 
correct position of " |bar", |mostBackWordPosition| of canonicalization
 moves to "| bar". We can fix it changing function signature from 
 VisiblePosition to Position. However it changes editing code widely.
I think that is a kind of refactoring, but that is massive change. I will
 do it after branch-cut.




BUG=658765
TEST=webkit_unit_test
--gtest_filter=FrameSelectionTest.SelectWordAroundPosition2, by hand with
https://jsfiddle.net/fpt03tv5/1/
==========

[yosin_UTC9, 2017-03-01 03:31:07]

lgtm w/ nits

https://codereview.chromium.org/2723913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right):

https://codereview.chromium.org/2723913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelection.cpp:1078: static bool
hasWord(const String& text) {
nit: s/hasWord/hasNonSeparatorCharacter/

Since the term "word" has ambiguous and this function just checks non separator
character.

https://codereview.chromium.org/2723913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp (right):

https://codereview.chromium.org/2723913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:137: Node* const
baz = document().body()->firstChild()->childNodes()->item(2);
document().body()->firstChild()->lastChild() is easier and we don't need to
include "NodeList.h"

[yoichio, 2017-03-01 03:41:38]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-03-01 03:41:39]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2723913002/#ps40001
(title: "update")

[commit-bot: I haz the power, 2017-03-01 03:41:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-01 03:42:10]

https://codereview.chromium.org/2723913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameSelection.cpp (right):

https://codereview.chromium.org/2723913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelection.cpp:1078: static bool
hasWord(const String& text) {
On 2017/03/01 03:31:03, yosin_UTC9 wrote:
> nit: s/hasWord/hasNonSeparatorCharacter/
> 
> Since the term "word" has ambiguous and this function just checks non
separator
> character.

Done.

https://codereview.chromium.org/2723913002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp (right):

https://codereview.chromium.org/2723913002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp:137: Node* const
baz = document().body()->firstChild()->childNodes()->item(2);
On 2017/03/01 03:31:03, yosin_UTC9 wrote:
> document().body()->firstChild()->lastChild() is easier and we don't need to
> include "NodeList.h"

Done.

[Donn Denman, 2017-03-01 04:03:19]

lgtm

[commit-bot: I haz the power, 2017-03-01 06:08:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488339698388740,
"parent_rev": "cadc590d928f938727c8f50f5270f3216d43613c", "commit_rev":
"8b8542139c3680bd68c6fa07b3df6cfd8706b3c9"}

[commit-bot: I haz the power, 2017-03-01 06:09:48]

Description was changed from

==========
Relax text validation in FrameSelection::selectWordAroundPosition

This CL fixes text select failure in the cases that |startOfWord|
 returns VisiblePosition before space like " bar".
In that case, selectWordAroundPosition failed.

This CL covers the case to check text contains characters rather than
 separators.

The root cause is that though |previousBoundary| in |startOfWord| finds 
correct position of " |bar", |mostBackWordPosition| of canonicalization
 moves to "| bar". We can fix it changing function signature from 
 VisiblePosition to Position. However it changes editing code widely.
I think that is a kind of refactoring, but that is massive change. I will
 do it after branch-cut.




BUG=658765
TEST=webkit_unit_test
--gtest_filter=FrameSelectionTest.SelectWordAroundPosition2, by hand with
https://jsfiddle.net/fpt03tv5/1/
==========

to

==========
Relax text validation in FrameSelection::selectWordAroundPosition

This CL fixes text select failure in the cases that |startOfWord|
 returns VisiblePosition before space like " bar".
In that case, selectWordAroundPosition failed.

This CL covers the case to check text contains characters rather than
 separators.

The root cause is that though |previousBoundary| in |startOfWord| finds 
correct position of " |bar", |mostBackWordPosition| of canonicalization
 moves to "| bar". We can fix it changing function signature from 
 VisiblePosition to Position. However it changes editing code widely.
I think that is a kind of refactoring, but that is massive change. I will
 do it after branch-cut.




BUG=658765
TEST=webkit_unit_test
--gtest_filter=FrameSelectionTest.SelectWordAroundPosition2, by hand with
https://jsfiddle.net/fpt03tv5/1/

Review-Url: https://codereview.chromium.org/2723913002
Cr-Commit-Position: refs/heads/master@{#453860}
Committed:
https://chromium.googlesource.com/chromium/src/+/8b8542139c3680bd68c6fa07b3df...
==========

[commit-bot: I haz the power, 2017-03-01 06:09:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8b8542139c3680bd68c6fa07b3df...