MD WebUI: change all <dom-module> to use id="" instead of name=""

MD WebUI: change all <dom-module> to use id="" instead of name=""

polymer-css-build only looks for id="", even though name="" is also
respected by the runtime Polymer core library.

R=dpapad@chromium.org
BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2723873003
Cr-Commit-Position: refs/heads/master@{#454117}
Committed: https://chromium.googlesource.com/chromium/src/+/f4e34a7ec3173920fd123c4d00692429bf5ab16e

[Dan Beam, 2017-03-01 22:58:05]

Description was changed from

==========
MD WebUI: change all <dom-module> to use id="" instead of name=""

polymer-css-build only looks for id="", even though name="" is also
respected by the runtime Polymer core library.

R=dpapad@chromium.org
BUG=597347
==========

to

==========
MD WebUI: change all <dom-module> to use id="" instead of name=""

polymer-css-build only looks for id="", even though name="" is also
respected by the runtime Polymer core library.

R=dpapad@chromium.org
BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-03-01 22:59:50]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 23:00:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-03-01 23:20:18]

LGTM. I assume you are adding the PRESUBMIT check in a separate CL? Did not see
it here.

https://codereview.chromium.org/2723873003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html (right):

https://codereview.chromium.org/2723873003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html:13: <link
rel="stylesheet" href="oobe_dialog_host.css">
Unrelated to this CL:
I am curious on how this works (does it?) I thought the only way to include a
CSS file in a custom element was with

link rel="import" type="css"

(which is deprecated https://github.com/Polymer/docs/issues/1347).

[Dan Beam, 2017-03-02 00:00:29]

https://codereview.chromium.org/2723873003/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html (right):

https://codereview.chromium.org/2723873003/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html:13: <link
rel="stylesheet" href="oobe_dialog_host.css">
On 2017/03/01 23:20:18, dpapad wrote:
> Unrelated to this CL:
> I am curious on how this works (does it?) I thought the only way to include a
> CSS file in a custom element was with
> 
> link rel="import" type="css"
> 
> (which is deprecated https://github.com/Polymer/docs/issues/1347).

flattenhtml="true" maybe

https://cs.chromium.org/chromium/src/chrome/browser/browser_resources.grd?typ...

[Dan Beam, 2017-03-02 00:00:49]

On 2017/03/01 23:20:18, dpapad wrote:
> LGTM. I assume you are adding the PRESUBMIT check in a separate CL? Did not
see
> it here.

yeah, separate

[Dan Beam, 2017-03-02 00:00:59]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2017-03-02 00:01:02]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-03-02 00:01:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 00:26:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488412862103370, "parent_rev":
"76b2e14f1162043e7a91f000250c8b6dd996a609", "commit_rev":
"f4e34a7ec3173920fd123c4d00692429bf5ab16e"}

[commit-bot: I haz the power, 2017-03-02 00:27:38]

Description was changed from

==========
MD WebUI: change all <dom-module> to use id="" instead of name=""

polymer-css-build only looks for id="", even though name="" is also
respected by the runtime Polymer core library.

R=dpapad@chromium.org
BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: change all <dom-module> to use id="" instead of name=""

polymer-css-build only looks for id="", even though name="" is also
respected by the runtime Polymer core library.

R=dpapad@chromium.org
BUG=597347
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2723873003
Cr-Commit-Position: refs/heads/master@{#454117}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4e34a7ec3173920fd123c4d0069...
==========

[commit-bot: I haz the power, 2017-03-02 00:27:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4e34a7ec3173920fd123c4d0069...