Mus Demo: Add a comment line switch for launching multiple windows in external mode

Mus Demo: Add a comment line switch for launching multiple windows in
external mode.

Make it possible to launch multiple (external) mus_demo windows from
the command line:

TEST=$ <out>/mash --ozone-platform={x11|wayland} --service=mus_demo --external-window-count=N

BUG=666958
Note that this will used by mus_demo_unittests too in [1].

[1] https://codereview.chromium.org/2715533005/

Review-Url: https://codereview.chromium.org/2723853004
Cr-Commit-Position: refs/heads/master@{#453984}
Committed: https://chromium.googlesource.com/chromium/src/+/c1517f207db34e85c4c1744aa7c06b0b6eb24fee

[tonikitoo, 2017-03-01 14:56:03]

tonikitoo@igalia.com changed reviewers:
+ kylechar@chromium.org

[tonikitoo, 2017-03-01 14:56:04]

PTAL

[tonikitoo, 2017-03-01 14:56:56]

Description was changed from

==========
Add a comment line switch for launching multiple windows in external mode

BUG=666958
==========

to

==========
Mus Demo: Add a comment line switch for launching multiple windows in
external mode.

BUG=666958
==========

[fwang, 2017-03-01 15:00:27]

fwang@igalia.com changed reviewers:
+ fwang@igalia.com

[fwang, 2017-03-01 15:00:27]

informal l-g-t-m

[tonikitoo, 2017-03-01 18:37:16]

Description was changed from

==========
Mus Demo: Add a comment line switch for launching multiple windows in
external mode.

BUG=666958
==========

to

==========
Mus Demo: Add a comment line switch for launching multiple windows in
external mode.

Make it possible to launch multiple (external) mus_demo windows from
the command line:

TEST=$ <out>/mash --ozone-platform={x11|wayland} --service=mus_demo
--external-window-count=N

BUG=666958

Note that this will used by mus_demo_unittests too in [1].

[1] https://codereview.chromium.org/2715533005/
==========

[kylechar, 2017-03-01 18:39:07]

https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_de...
File services/ui/demo/mus_demo_external.cc (right):

https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_de...
services/ui/demo/mus_demo_external.cc:66: return;
What happens if we return here without creating anything?

[tonikitoo, 2017-03-01 18:41:34]

On 2017/03/01 18:39:07, kylechar wrote:
>
https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_de...
> File services/ui/demo/mus_demo_external.cc (right):
> 
>
https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_de...
> services/ui/demo/mus_demo_external.cc:66: return;
> What happens if we return here without creating anything?

I see a

  [17475:17475:0301/143842.195347:333078375878:ERROR:mus_demo_external.cc(60)]
Invalid value for 'external-window-count'

warning on console, and it hangs ('till I kill it with control+c). Maybe we
better just default to one in this case?

[kylechar, 2017-03-01 18:42:29]

On 2017/03/01 18:41:34, tonikitoo wrote:
> On 2017/03/01 18:39:07, kylechar wrote:
> >
>
https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_de...
> > File services/ui/demo/mus_demo_external.cc (right):
> > 
> >
>
https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_de...
> > services/ui/demo/mus_demo_external.cc:66: return;
> > What happens if we return here without creating anything?
> 
> I see a
> 
>   [17475:17475:0301/143842.195347:333078375878:ERROR:mus_demo_external.cc(60)]
> Invalid value for 'external-window-count'
> 
> warning on console, and it hangs ('till I kill it with control+c). Maybe we
> better just default to one in this case?

LOG(FATAL) could work too.

[tonikitoo, 2017-03-01 18:46:51]

On 2017/03/01 18:42:29, kylechar wrote:
> On 2017/03/01 18:41:34, tonikitoo wrote:
> > On 2017/03/01 18:39:07, kylechar wrote:
> > >
> >
>
https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_de...
> > > File services/ui/demo/mus_demo_external.cc (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_de...
> > > services/ui/demo/mus_demo_external.cc:66: return;
> > > What happens if we return here without creating anything?
> > 
> > I see a
> > 
> >  
[17475:17475:0301/143842.195347:333078375878:ERROR:mus_demo_external.cc(60)]
> > Invalid value for 'external-window-count'
> > 
> > warning on console, and it hangs ('till I kill it with control+c). Maybe we
> > better just default to one in this case?
> 
> LOG(FATAL) could work too.

Done

[kylechar, 2017-03-01 18:48:26]

lgtm

[tonikitoo, 2017-03-01 18:49:30]

The CQ bit was checked by tonikitoo@igalia.com

[commit-bot: I haz the power, 2017-03-01 18:49:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 19:01:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488394170220780,
"parent_rev": "1e806b1e34b10601573dc18d6ebfafd40651d40f", "commit_rev":
"c1517f207db34e85c4c1744aa7c06b0b6eb24fee"}

[commit-bot: I haz the power, 2017-03-01 19:02:16]

Description was changed from

==========
Mus Demo: Add a comment line switch for launching multiple windows in
external mode.

Make it possible to launch multiple (external) mus_demo windows from
the command line:

TEST=$ <out>/mash --ozone-platform={x11|wayland} --service=mus_demo
--external-window-count=N

BUG=666958

Note that this will used by mus_demo_unittests too in [1].

[1] https://codereview.chromium.org/2715533005/
==========

to

==========
Mus Demo: Add a comment line switch for launching multiple windows in
external mode.

Make it possible to launch multiple (external) mus_demo windows from
the command line:

TEST=$ <out>/mash --ozone-platform={x11|wayland} --service=mus_demo
--external-window-count=N

BUG=666958

Note that this will used by mus_demo_unittests too in [1].

[1] https://codereview.chromium.org/2715533005/

Review-Url: https://codereview.chromium.org/2723853004
Cr-Commit-Position: refs/heads/master@{#453984}
Committed:
https://chromium.googlesource.com/chromium/src/+/c1517f207db34e85c4c1744aa7c0...
==========

[commit-bot: I haz the power, 2017-03-01 19:02:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c1517f207db34e85c4c1744aa7c0...