Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 2723853004: Mus Demo: Add a comment line switch for launching multiple windows in external mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by tonikitoo
Modified:
6 months, 3 weeks ago
Reviewers:
kylechar, fwang
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus Demo: Add a comment line switch for launching multiple windows in external mode. Make it possible to launch multiple (external) mus_demo windows from the command line: TEST=$ <out>/mash --ozone-platform={x11|wayland} --service=mus_demo --external-window-count=N BUG=666958 Note that this will used by mus_demo_unittests too in [1]. [1] https://codereview.chromium.org/2715533005/ Review-Url: https://codereview.chromium.org/2723853004 Cr-Commit-Position: refs/heads/master@{#453984} Committed: https://chromium.googlesource.com/chromium/src/+/c1517f207db34e85c4c1744aa7c06b0b6eb24fee

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : addressed kylechar feedback #

Messages

Total messages: 16 (7 generated)
tonikitoo
PTAL
6 months, 3 weeks ago (2017-03-01 14:56:04 UTC) #2
fwang
informal l-g-t-m
6 months, 3 weeks ago (2017-03-01 15:00:27 UTC) #5
kylechar
https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_demo_external.cc File services/ui/demo/mus_demo_external.cc (right): https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_demo_external.cc#newcode66 services/ui/demo/mus_demo_external.cc:66: return; What happens if we return here without creating ...
6 months, 3 weeks ago (2017-03-01 18:39:07 UTC) #7
tonikitoo
On 2017/03/01 18:39:07, kylechar wrote: > https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_demo_external.cc > File services/ui/demo/mus_demo_external.cc (right): > > https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_demo_external.cc#newcode66 > ...
6 months, 3 weeks ago (2017-03-01 18:41:34 UTC) #8
kylechar
On 2017/03/01 18:41:34, tonikitoo wrote: > On 2017/03/01 18:39:07, kylechar wrote: > > > https://codereview.chromium.org/2723853004/diff/20001/services/ui/demo/mus_demo_external.cc ...
6 months, 3 weeks ago (2017-03-01 18:42:29 UTC) #9
tonikitoo
On 2017/03/01 18:42:29, kylechar wrote: > On 2017/03/01 18:41:34, tonikitoo wrote: > > On 2017/03/01 ...
6 months, 3 weeks ago (2017-03-01 18:46:51 UTC) #10
kylechar
lgtm
6 months, 3 weeks ago (2017-03-01 18:48:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723853004/40001
6 months, 3 weeks ago (2017-03-01 18:49:52 UTC) #13
commit-bot: I haz the power
6 months, 3 weeks ago (2017-03-01 19:02:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c1517f207db34e85c4c1744aa7c0...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b