base/containers/flat_set_unittest.cc - Issue 2723853002: Implementing erase/erase_if functions from library fundamentals ts:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/containers/flat_set_unittest.cc

Issue 2723853002: Implementing erase/erase_if functions from library fundamentals ts: (Closed)

Patch Set: Review, round 2. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/containers/flat_set_unittest.cc

diff --git a/base/containers/flat_set_unittest.cc b/base/containers/flat_set_unittest.cc

index 1c7a46a026f3da16d366b234092b6482410551d6..c88186aeb379a5bb1c7a6eeccbe5d5a0673fa772 100644

--- a/base/containers/flat_set_unittest.cc

+++ b/base/containers/flat_set_unittest.cc

@@ -1242,3 +1242,5 @@ TEST(FlatSet, Comparison) {

EXPECT_GE(biggest, middle);

EXPECT_GE(biggest, biggest);

}

+// STLEraseIf(FlatSet) is tested in stl_util_unittests.cc

danakj 2017/03/03 23:51:22 remove this, throw a test here if you like?

dyaroshev 2017/03/04 00:32:49 Done.