base/containers/flat_set_unittest.cc - Issue 2723853002: Implementing erase/erase_if functions from library fundamentals ts:

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/containers/flat_set_unittest.cc

Issue 2723853002: Implementing erase/erase_if functions from library fundamentals ts: (Closed)

Patch Set: Review, round 2. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« base/containers/flat_set.h ('K') | « base/containers/flat_set.h ('k') | base/stl_util.h » ('j') | base/stl_util.h » ('J')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/containers/flat_set.h"	5 #include "base/containers/flat_set.h"

6	6

7 // Following tests are ported and extended tests from libcpp for std::set.	7 // Following tests are ported and extended tests from libcpp for std::set.

8 // They can be found here:	8 // They can be found here:

9 // https://github.com/llvm-mirror/libcxx/tree/master/test/std/containers/associa tive/set	9 // https://github.com/llvm-mirror/libcxx/tree/master/test/std/containers/associa tive/set

10 //	10 //

(...skipping 1224 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1235	1235

1236 EXPECT_EQ(biggest, biggest);	1236 EXPECT_EQ(biggest, biggest);

1237 EXPECT_NE(biggest, smallest);	1237 EXPECT_NE(biggest, smallest);

1238 EXPECT_LT(smallest, middle);	1238 EXPECT_LT(smallest, middle);

1239 EXPECT_LE(smallest, middle);	1239 EXPECT_LE(smallest, middle);

1240 EXPECT_LE(middle, middle);	1240 EXPECT_LE(middle, middle);

1241 EXPECT_GT(biggest, middle);	1241 EXPECT_GT(biggest, middle);

1242 EXPECT_GE(biggest, middle);	1242 EXPECT_GE(biggest, middle);

1243 EXPECT_GE(biggest, biggest);	1243 EXPECT_GE(biggest, biggest);

1244 }	1244 }

	1245

	1246 // STLEraseIf(FlatSet) is tested in stl_util_unittests.cc
	danakj 2017/03/03 23:51:22 remove this, throw a test here if you like? remove this, throw a test here if you like? dyaroshev 2017/03/04 00:32:49 Done. Show quoted text On 2017/03/03 23:51:22, danakj wrote: > remove this, throw a test here if you like? Done.
OLD	NEW