DevTools: restore array lengths for long arrays

DevTools: restore array lengths for long arrays

After merging the two array formats, all arrays printed in the console had no
length visible in the description. This CL takes array length hints out from the
'Object previews' experiment to address the regression.

BUG=697155
Review-Url: https://codereview.chromium.org/2723773003
Cr-Commit-Position: refs/heads/master@{#454061}
Committed: https://chromium.googlesource.com/chromium/src/+/eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5

[luoe, 2017-02-28 20:37:53]

Description was changed from

==========
DevTools: restore array lengths for long arrays

BUG=697155
==========

to

==========
DevTools: restore array lengths for long arrays

After merging the two array formats, all arrays printed in the console had no
length visible in the description. This CL takes array length hints out from the
'Object previews' experiment to address the regression.

BUG=697155
==========

[luoe, 2017-02-28 20:38:29]

luoe@chromium.org changed reviewers:
+ dgozman@chromium.org, lushnikov@chromium.org

[luoe, 2017-02-28 20:38:30]

Please take a look!

[lushnikov, 2017-02-28 22:21:08]

https://codereview.chromium.org/2723773003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js
(right):

https://codereview.chromium.org/2723773003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js:35:
const size = SDK.RemoteObject.arrayLength(preview) ||
SDK.RemoteObject.mapOrSetEntriesCount(preview);
value of mapOrSetEntriesCount is never used

the value of arrayLength could be computed only inside the
if(isArrayOrTypedArray).. condition

https://codereview.chromium.org/2723773003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js:36:
var text = preview.subtype === 'typedarray' ?
SDK.RemoteObject.arrayNameFromDescription(description) : '';
this should go under isArrayOrTypedArray as well

https://codereview.chromium.org/2723773003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js:40:
var hideObjectKeyword = previewExperimentEnabled && description === 'Object';
hideDescription?

[luoe, 2017-02-28 22:32:57]

ptal

https://codereview.chromium.org/2723773003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js
(right):

https://codereview.chromium.org/2723773003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js:35:
const size = SDK.RemoteObject.arrayLength(preview) ||
SDK.RemoteObject.mapOrSetEntriesCount(preview);
On 2017/02/28 22:21:08, lushnikov wrote:
> value of mapOrSetEntriesCount is never used
> 
> the value of arrayLength could be computed only inside the
> if(isArrayOrTypedArray).. condition

Done.

https://codereview.chromium.org/2723773003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js:36:
var text = preview.subtype === 'typedarray' ?
SDK.RemoteObject.arrayNameFromDescription(description) : '';
On 2017/02/28 22:21:08, lushnikov wrote:
> this should go under isArrayOrTypedArray as well

Done.

https://codereview.chromium.org/2723773003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js:40:
var hideObjectKeyword = previewExperimentEnabled && description === 'Object';
On 2017/02/28 22:21:08, lushnikov wrote:
> hideDescription?

Done.

[dgozman, 2017-03-01 19:57:19]

lgtm

[luoe, 2017-03-01 19:57:36]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 19:58:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:27:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 21:27:06]

Dry run: This issue passed the CQ dry run.

[luoe, 2017-03-01 21:49:07]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-03-01 21:49:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:11:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488404947894770,
"parent_rev": "8daac32c17f494d496fb2ca3768d67d9bd77db5e", "commit_rev":
"eecc13e01b6a45274c7f18cc2aa4ea83f69eb8c5"}

[commit-bot: I haz the power, 2017-03-01 22:12:22]

Description was changed from

==========
DevTools: restore array lengths for long arrays

After merging the two array formats, all arrays printed in the console had no
length visible in the description. This CL takes array length hints out from the
'Object previews' experiment to address the regression.

BUG=697155
==========

to

==========
DevTools: restore array lengths for long arrays

After merging the two array formats, all arrays printed in the console had no
length visible in the description. This CL takes array length hints out from the
'Object previews' experiment to address the regression.

BUG=697155

Review-Url: https://codereview.chromium.org/2723773003
Cr-Commit-Position: refs/heads/master@{#454061}
Committed:
https://chromium.googlesource.com/chromium/src/+/eecc13e01b6a45274c7f18cc2aa4...
==========

[commit-bot: I haz the power, 2017-03-01 22:12:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eecc13e01b6a45274c7f18cc2aa4...