Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2723773002: tracing: Introduce mojo Interfaces (Closed)

Created:
3 years, 9 months ago by chiniforooshan
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, chrome-grc-reviews_chromium.org, chromium-reviews, darin (slow to review), Primiano Tucci (use gerrit), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tracing: Introduce mojo Interfaces Memory-infra IPCs were translated to mojo in a series of patches, before. This CL introduces the mojo interface for all other parts, except for background tracing, which will be dealt with in a separate CL. For documentation of the interface, please refer to the comments inside the mojom file. BUG=640235 Review-Url: https://codereview.chromium.org/2723773002 Cr-Commit-Position: refs/heads/master@{#455800} Committed: https://chromium.googlesource.com/chromium/src/+/474d0213e93f623d92acb750fcdcd48c60a34c6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M services/resource_coordinator/public/interfaces/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
A services/resource_coordinator/public/interfaces/tracing/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A services/resource_coordinator/public/interfaces/tracing/tracing.mojom View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
chiniforooshan
Hi Oystein, Fadi, This is just a proposal for the eventual tracing mojo interface (background ...
3 years, 9 months ago (2017-02-28 18:59:38 UTC) #2
chiniforooshan
CC Primiano
3 years, 9 months ago (2017-02-28 19:14:06 UTC) #3
chiniforooshan
+chrome-grc-reviews@
3 years, 9 months ago (2017-02-28 20:19:30 UTC) #4
chiniforooshan
ping
3 years, 9 months ago (2017-03-06 15:23:37 UTC) #6
lpy
Just curious, is there any doc about tracing servicification?
3 years, 9 months ago (2017-03-06 18:07:56 UTC) #7
chiniforooshan
On 2017/03/06 18:07:56, lpy wrote: > Just curious, is there any doc about tracing servicification? ...
3 years, 9 months ago (2017-03-06 18:19:38 UTC) #8
oystein (OOO til 10th of July)
Apologies for the late response; lgtm.
3 years, 9 months ago (2017-03-07 21:05:01 UTC) #9
oystein (OOO til 10th of July)
Apologies for the late response; lgtm.
3 years, 9 months ago (2017-03-07 21:05:01 UTC) #10
chiniforooshan
Thanks! +kenrb for security review of tracing.mojom.
3 years, 9 months ago (2017-03-07 21:10:57 UTC) #12
kenrb
lgtm, bug please ensure there is security review for the interface implementations even if there ...
3 years, 9 months ago (2017-03-09 16:37:31 UTC) #13
chiniforooshan
On 2017/03/09 16:37:31, kenrb wrote: > lgtm, bug please ensure there is security review for ...
3 years, 9 months ago (2017-03-09 17:20:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723773002/1
3 years, 9 months ago (2017-03-09 17:21:10 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 18:31:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/474d0213e93f623d92acb750fcdc...

Powered by Google App Engine
This is Rietveld 408576698