Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2723753002: [Reland] Some linked_ptr removal in chromeos file_browser_handler. (Closed)

Created:
3 years, 9 months ago by lazyboy
Modified:
3 years, 9 months ago
Reviewers:
hirono, nhiroki
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] Some linked_ptr removal in chromeos file_browser_handler. Original CL: https://chromium.googlesource.com/chromium/src/+/37ab3be841440d4ec5abf1160acf32c905796d13 was reverted due to unit_tests failure on chromeos debug bots. There was an ownership issue in volume_manager.cc which this CL fixes. BUG=556939, 696375 Test=No visible changes. Ran VolumeManagerTest.* in debug, which passes now. Review-Url: https://codereview.chromium.org/2723753002 Cr-Commit-Position: refs/heads/master@{#454742} Committed: https://chromium.googlesource.com/chromium/src/+/a9d4fa4f3133c0fbd0a48d01846ec8968cfe2926

Patch Set 1 #

Patch Set 2 : FIX #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -109 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/job_event_router_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 5 chunks +22 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 26 chunks +86 lines, -81 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
lazyboy
+nhiroki@, Patch Set #1 is the reverted CL. Patch Set #2 contains the fix.
3 years, 9 months ago (2017-02-28 22:05:05 UTC) #6
nhiroki
Sorry for my delayed reply. I'm not an owner of the file_manager. +hirono@, can you ...
3 years, 9 months ago (2017-03-02 09:13:29 UTC) #8
hirono
lgtm, thank you for fixing!
3 years, 9 months ago (2017-03-02 10:14:27 UTC) #9
lazyboy
On 2017/03/02 09:13:29, nhiroki (slow) wrote: > Sorry for my delayed reply. I'm not an ...
3 years, 9 months ago (2017-03-03 02:41:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723753002/20001
3 years, 9 months ago (2017-03-04 01:28:09 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 01:34:13 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a9d4fa4f3133c0fbd0a48d01846e...

Powered by Google App Engine
This is Rietveld 408576698