Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2723743002: [Mac] Remove unnecessary subclasses in bookmark bar (Closed)

Created:
3 years, 9 months ago by lgrey
Modified:
3 years, 9 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Remove unnecessary subclasses in bookmark bar We no longer build on the 10.6 SDK BUG=648560 Review-Url: https://codereview.chromium.org/2723743002 Cr-Commit-Position: refs/heads/master@{#453654} Committed: https://chromium.googlesource.com/chromium/src/+/ca58fea9d8ea3d1e63abdc427f9a5326b581b2ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -44 lines) Patch
M chrome/app/nibs/BookmarkBar.xib View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.h View 3 chunks +4 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm View 2 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lgrey
PTAL :)
3 years, 9 months ago (2017-02-28 18:47:09 UTC) #6
Elly Fong-Jones
lgtm
3 years, 9 months ago (2017-02-28 18:58:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723743002/1
3 years, 9 months ago (2017-02-28 18:59:56 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 19:05:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca58fea9d8ea3d1e63abdc427f9a...

Powered by Google App Engine
This is Rietveld 408576698