Add Physical Web OnInitialDisplay Uma

This UMA was logged in ListUrlsActivity.java.
That file is deprecated so we lost that UMA.
Re-log it in WebUI.

BUG=697130
Review-Url: https://codereview.chromium.org/2723633002
Cr-Commit-Position: refs/heads/master@{#454040}
Committed: https://chromium.googlesource.com/chromium/src/+/af14b80b50075629e1377736425000c609f7a4ac

[Ran, 2017-02-27 20:58:41]

Description was changed from

==========
Add OnInitialDisplay Uma

BUG=
==========

to

==========
Add Physical Web OnInitialDisplay Uma

BUG=
==========

[Ran, 2017-02-27 21:01:30]

ranj@chromium.org changed reviewers:
+ cco3@chromium.org, mattreynolds@chromium.org

[mattreynolds, 2017-02-27 21:24:38]

lgtm

[cco3, 2017-02-28 00:02:10]

lgtm, just add a bug number

[Ran, 2017-02-28 18:55:14]

The CQ bit was checked by ranj@chromium.org

[Ran, 2017-02-28 18:55:24]

The CQ bit was unchecked by ranj@chromium.org

[Ran, 2017-02-28 18:59:49]

Description was changed from

==========
Add Physical Web OnInitialDisplay Uma

BUG=
==========

to

==========
Add Physical Web OnInitialDisplay Uma

BUG=697130
==========

[Ran, 2017-02-28 19:00:17]

The CQ bit was checked by ranj@chromium.org

[commit-bot: I haz the power, 2017-02-28 19:00:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 19:00:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 19:00:44]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Ran, 2017-02-28 19:09:38]

ranj@chromium.org changed reviewers:
+ nyquist@chromium.org

[Ran, 2017-02-28 19:09:47]

+nyquist

[nyquist, 2017-02-28 19:47:23]

https://codereview.chromium.org/2723633002/diff/20001/components/physical_web...
File components/physical_web/webui/physical_web_base_message_handler.cc (right):

https://codereview.chromium.org/2723633002/diff/20001/components/physical_web...
components/physical_web/webui/physical_web_base_message_handler.cc:60:
UMA_HISTOGRAM_EXACT_LINEAR("PhysicalWeb.TotalUrls.OnInitialDisplay",
This seems to also be reported from PhysicalWebUma.java. Is that intentional?

[Ran, 2017-02-28 20:06:12]

https://codereview.chromium.org/2723633002/diff/20001/components/physical_web...
File components/physical_web/webui/physical_web_base_message_handler.cc (right):

https://codereview.chromium.org/2723633002/diff/20001/components/physical_web...
components/physical_web/webui/physical_web_base_message_handler.cc:60:
UMA_HISTOGRAM_EXACT_LINEAR("PhysicalWeb.TotalUrls.OnInitialDisplay",
On 2017/02/28 19:47:23, nyquist wrote:
> This seems to also be reported from PhysicalWebUma.java. Is that intentional?

Yes, this UMA in PhysicalWebUma.java was get called in
"chrome/browser/physicalweb/ListUrlsActivity.java". This file is no longer used
and so we should log it somewhere else.

It reminders us to do a clean up.

[nyquist, 2017-02-28 22:44:36]

OK. But can you then update the CL description.

I find that most CL descriptions can be made helpful by writing one paragraph
for each of these questions:
- What happened before this CL?
- Why is that bad?
- How does this CL make it better?

the code lgtm though

[Ran, 2017-03-01 18:35:07]

The CQ bit was checked by ranj@chromium.org

[commit-bot: I haz the power, 2017-03-01 18:35:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 19:26:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 19:26:48]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Ran, 2017-03-01 20:21:57]

The CQ bit was checked by ranj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:22:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ran, 2017-03-01 20:26:10]

Description was changed from

==========
Add Physical Web OnInitialDisplay Uma

BUG=697130
==========

to

==========
This UMA was logged in ListUrlsActivity.java.

That file is deprecated so we lost that UMA.

Re-log it in WebUI

BUG=697130
==========

[Ran, 2017-03-01 20:26:26]

Description was changed from

==========
This UMA was logged in ListUrlsActivity.java.

That file is deprecated so we lost that UMA.

Re-log it in WebUI

BUG=697130
==========

to

==========
This UMA was logged in ListUrlsActivity.java.
That file is deprecated so we lost that UMA.
Re-log it in WebUI

BUG=697130
==========

[Ran, 2017-03-01 20:27:04]

Description was changed from

==========
This UMA was logged in ListUrlsActivity.java.
That file is deprecated so we lost that UMA.
Re-log it in WebUI

BUG=697130
==========

to

==========
This UMA was logged in ListUrlsActivity.java.
That file is deprecated so we lost that UMA.
Re-log it in WebUI.

BUG=697130
==========

[commit-bot: I haz the power, 2017-03-01 21:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 21:14:23]

Dry run: This issue passed the CQ dry run.

[Ran, 2017-03-01 21:16:54]

The CQ bit was checked by ranj@chromium.org

[Ran, 2017-03-01 21:16:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, cco3@chromium.org, mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2723633002/#ps40001
(title: "fix tests")

[commit-bot: I haz the power, 2017-03-01 21:17:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 21:30:22]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488403014815870,
"parent_rev": "1ee8493dad2494e89b2417453c030da69f89137a", "commit_rev":
"af14b80b50075629e1377736425000c609f7a4ac"}

[commit-bot: I haz the power, 2017-03-01 21:30:57]

Description was changed from

==========
This UMA was logged in ListUrlsActivity.java.
That file is deprecated so we lost that UMA.
Re-log it in WebUI.

BUG=697130
==========

to

==========
This UMA was logged in ListUrlsActivity.java.
That file is deprecated so we lost that UMA.
Re-log it in WebUI.

BUG=697130

Review-Url: https://codereview.chromium.org/2723633002
Cr-Commit-Position: refs/heads/master@{#454040}
Committed:
https://chromium.googlesource.com/chromium/src/+/af14b80b50075629e13777364250...
==========

[commit-bot: I haz the power, 2017-03-01 21:30:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/af14b80b50075629e13777364250...

[mmocny, 2017-03-02 17:00:01]

On 2017/03/01 21:30:59, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/af14b80b50075629e13777364250...

Ran: for future reference, the very first line of description is a summary of
the patch.  Tommy's suggestion of the three questions is great for the body of
the description, but the first line would be good to keep as a brief summary of
the patch.