Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2723623004: Get PageLoadMetricsBrowserTest passing under msan (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get PageLoadMetricsBrowserTest passing under msan https://codereview.chromium.org/2698813005 forgot to initialize a field it added. BUG=697173 Review-Url: https://codereview.chromium.org/2723623004 Cr-Commit-Position: refs/heads/master@{#453708} Committed: https://chromium.googlesource.com/chromium/src/+/6557cd40deb894148068183e4489ca264043d214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Nico
3 years, 9 months ago (2017-02-28 20:45:19 UTC) #3
Lei Zhang
lgtm
3 years, 9 months ago (2017-02-28 20:46:22 UTC) #6
Charlie Harrison
drive by lgtm
3 years, 9 months ago (2017-02-28 20:46:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723623004/1
3 years, 9 months ago (2017-02-28 20:47:19 UTC) #11
mattcary
lgtm Grr, silly mistake. Thanks for the fix.
3 years, 9 months ago (2017-02-28 21:27:06 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 21:38:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6557cd40deb894148068183e4489...

Powered by Google App Engine
This is Rietveld 408576698