Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2723623002: DevTools: fix object popover title (Closed)

Created:
3 years, 9 months ago by lushnikov
Modified:
3 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix object popover title Object popover title resides in a container; that's the one which should have "overflow: hidden", not the inner span. BUG=696712 R=dgozman Review-Url: https://codereview.chromium.org/2723623002 Cr-Commit-Position: refs/heads/master@{#453361} Committed: https://chromium.googlesource.com/chromium/src/+/fe1613f09089d4b570263393f7e7e2d9c88d23d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
lushnikov
please, take a look
3 years, 9 months ago (2017-02-27 20:49:33 UTC) #1
dgozman
lgtm
3 years, 9 months ago (2017-02-27 21:52:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723623002/1
3 years, 9 months ago (2017-02-27 22:19:38 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 22:31:44 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe1613f09089d4b570263393f7e7...

Powered by Google App Engine
This is Rietveld 408576698