Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2723613005:
Feedback Dialog: Fixes text wrapping issue for French. (Closed)
|
Created:
3 years, 9 months ago by sammiequon Modified:
3 years, 9 months ago Reviewers:
afakhry CC:
chromium-reviews, arv+watch_chromium.org, apacible+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFeedback Dialog: Fixes text wrapping issue for French.
It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the expected_report.mp4 in the bug. Tested for RTL as well.
TEST=manual
BUG=696913
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2723613005
Cr-Commit-Position: refs/heads/master@{#456147}
Committed: https://chromium.googlesource.com/chromium/src/+/67435cd8a4ae34c8005f848cb0a2e6b1ebabbafd
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
Description was changed from ========== Feedback Dialog: Fixes text wrapping issue for French. It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the actual_report.mp4 in the bug. Tested for RTL as well. TEST=manual BUG=696913 ========== to ========== Feedback Dialog: Fixes text wrapping issue for French. It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the actual_report.mp4 in the bug. Tested for RTL as well. TEST=manual BUG=696913 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Feedback Dialog: Fixes text wrapping issue for French. It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the actual_report.mp4 in the bug. Tested for RTL as well. TEST=manual BUG=696913 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Feedback Dialog: Fixes text wrapping issue for French. It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the actual_report.mp4 in the bug. Tested for RTL as well. TEST=manual BUG=696913 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
sammiequon@chromium.org changed reviewers: + afakhry@chromium.org
On 2017/02/28 21:45:37, sammiequon wrote: > mailto:sammiequon@chromium.org changed reviewers: > + mailto:afakhry@chromium.org afakhry@ - Please take a look. Thanks!
The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/03/01 17:18:59, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. like the actual_report.mp4 in the bug? I thought we wanted it to look like the Expected_Report.mp4?
Description was changed from ========== Feedback Dialog: Fixes text wrapping issue for French. It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the actual_report.mp4 in the bug. Tested for RTL as well. TEST=manual BUG=696913 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Feedback Dialog: Fixes text wrapping issue for French. It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the expected_report.mp4 in the bug. Tested for RTL as well. TEST=manual BUG=696913 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
On 2017/03/04 01:35:21, afakhry (OOO till 03-07) wrote: > On 2017/03/01 17:18:59, commit-bot: I haz the power wrote: > > Dry run: This issue passed the CQ dry run. > > like the actual_report.mp4 in the bug? I thought we wanted it to look like the > Expected_Report.mp4? Sorry I meant expected_report.mp4. Changed the description.
lgtm
On 2017/03/10 19:07:39, afakhry wrote: > lgtm Thanks!
The CQ bit was checked by sammiequon@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489173644212620, "parent_rev":
"7c7480d0133cf45df2cc7afe6acb84425678a7af", "commit_rev":
"67435cd8a4ae34c8005f848cb0a2e6b1ebabbafd"}
Message was sent while issue was closed.
Description was changed from ========== Feedback Dialog: Fixes text wrapping issue for French. It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the expected_report.mp4 in the bug. Tested for RTL as well. TEST=manual BUG=696913 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Feedback Dialog: Fixes text wrapping issue for French. It is said to be a M57 regression, but no one has touchedthe feedback dialog for a while. Regardless, this CL makes the dialog look like the expected_report.mp4 in the bug. Tested for RTL as well. TEST=manual BUG=696913 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2723613005 Cr-Commit-Position: refs/heads/master@{#456147} Committed: https://chromium.googlesource.com/chromium/src/+/67435cd8a4ae34c8005f848cb0a2... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/67435cd8a4ae34c8005f848cb0a2... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
