Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2723583003: Convert Ozone cast to use GLOzone API. (Closed)

Created:
3 years, 9 months ago by kylechar
Modified:
3 years, 9 months ago
Reviewers:
rjkroege, halliwell
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Ozone cast to use GLOzone API. Convert Ozone cast platform to use GLOzone instead of the old SurfaceFactoryOzone functions. This will allow deleting the deprecated functions in SurfaceFactoryOzone. Move all of the EGL related code from SurfaceFactoryCast into GLOzoneEglCast. The non-EGL code stays in SurfaceFactoryCast. Behaviour should be identical. This is purely a refactoring. BUG=643368 Review-Url: https://codereview.chromium.org/2723583003 Cr-Commit-Position: refs/heads/master@{#454295} Committed: https://chromium.googlesource.com/chromium/src/+/35f76e22347e0c129532872d681104f4a0ca51ed

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Add comment. #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -465 lines) Patch
M ui/ozone/platform/cast/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + ui/ozone/platform/cast/gl_ozone_egl_cast.h View 1 2 3 4 chunks +18 lines, -28 lines 0 comments Download
A + ui/ozone/platform/cast/gl_ozone_egl_cast.cc View 1 10 chunks +20 lines, -128 lines 0 comments Download
M ui/ozone/platform/cast/gl_surface_cast.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/cast/gl_surface_cast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.h View 1 2 chunks +6 lines, -41 lines 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.cc View 1 2 chunks +60 lines, -263 lines 0 comments Download
M ui/ozone/public/native_pixmap.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
kylechar
3 years, 9 months ago (2017-02-28 15:19:13 UTC) #4
kylechar
+rjkroege for ui/ozone/public/native_pixmap.h
3 years, 9 months ago (2017-03-02 13:50:54 UTC) #6
rjkroege
On 2017/03/02 13:50:54, kylechar wrote: > +rjkroege for ui/ozone/public/native_pixmap.h I note in passing that https://codereview.chromium.org/2688623004/ ...
3 years, 9 months ago (2017-03-02 15:44:03 UTC) #7
halliwell
On 2017/03/02 15:44:03, rjkroege wrote: > On 2017/03/02 13:50:54, kylechar wrote: > > +rjkroege for ...
3 years, 9 months ago (2017-03-02 16:05:31 UTC) #8
kylechar
Thanks! It looks like that change has the added #include in NativePixmap already, so it ...
3 years, 9 months ago (2017-03-02 16:09:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723583003/60001
3 years, 9 months ago (2017-03-02 16:58:31 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 17:32:11 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/35f76e22347e0c129532872d6811...

Powered by Google App Engine
This is Rietveld 408576698