Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2723503003:
Remove useless includes to ash_util.h (Closed)
|
Created:
3 years, 9 months ago by fwang Modified:
3 years, 9 months ago CC:
chromium-reviews, dbeam+watch-options_chromium.org, alemate+watch_chromium.org, sadrul, vabr+watchlistpasswordmanager_chromium.org, achuith+watch_chromium.org, michaelpg+watch-options_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, kalyank, gcasto+watchlist_chromium.org, sync-reviews_chromium.org, tonikitoo Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove useless includes to ash_util.h
BUG=697053
Review-Url: https://codereview.chromium.org/2723503003
Cr-Commit-Position: refs/heads/master@{#453851}
Committed: https://chromium.googlesource.com/chromium/src/+/b235f4c79955ce5987877c3b9513332cf7b306e6
Patch Set 1 #Patch Set 2 : remove dependency and fix presubmit warning #
Messages
Total messages: 39 (27 generated)
The CQ bit was checked by fwang@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fwang@igalia.com changed reviewers: + achuith@chromium.org, sky@chromium.org
PTAL
Description was changed from ========== Remove useless includes to ash_util.h BUG=None ========== to ========== Remove useless includes to ash_util.h BUG=None ==========
fwang@igalia.com changed reviewers: + tonikitoo@igalia.com
fwang@igalia.com changed reviewers: - tonikitoo@igalia.com
lgtm
Description was changed from ========== Remove useless includes to ash_util.h BUG=None ========== to ========== Remove useless includes to ash_util.h BUG=697053 ==========
LGTM
The CQ bit was checked by fwang@igalia.com
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2718333002 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by fwang@igalia.com
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/2723503003/#ps20001 (title: "rebase and remove dependency")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was unchecked by fwang@igalia.com
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by fwang@igalia.com
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/2723503003/#ps40001 (title: "remove dependency and fix presubmit warning")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
fwang@igalia.com changed reviewers: + stevenjb@chromium.org
@stevenjb: can you please review the change to chrome/browser/ui/webui/options/password_manager_handler.cc? I just realized that the "set noparent" rule prevents @sky from reviewing it...
The CQ bit was checked by fwang@igalia.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fwang@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488345134954410,
"parent_rev": "6d4bb28c8ba6e8bf8f53879aa02f0c823a0aa98d", "commit_rev":
"b235f4c79955ce5987877c3b9513332cf7b306e6"}
Message was sent while issue was closed.
Description was changed from ========== Remove useless includes to ash_util.h BUG=697053 ========== to ========== Remove useless includes to ash_util.h BUG=697053 Review-Url: https://codereview.chromium.org/2723503003 Cr-Commit-Position: refs/heads/master@{#453851} Committed: https://chromium.googlesource.com/chromium/src/+/b235f4c79955ce5987877c3b9513... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/b235f4c79955ce5987877c3b9513... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
