[heap] Use a separate concurrent store buffer processing flag.

[heap] Use a separate concurrent store buffer processing flag.

BUG=chromium:697049
Review-Url: https://codereview.chromium.org/2723473002
Cr-Commit-Position: refs/heads/master@{#43492}
Committed: https://chromium.googlesource.com/v8/v8/+/d05dede4cef58a1abfe3b733476f75fdea7fadda

[Hannes Payer (out of office), 2017-02-27 10:48:09]

hpayer@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2017-02-27 10:51:01]

lgtm with comment

https://codereview.chromium.org/2723473002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2723473002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:1251: DEFINE_NEG_IMPLICATION(single_threaded,
parallel_compaction)
Please add:
DEFINE_NEG_IMPLICATION(single_threaded, concurrent_store_buffer)

[Hannes Payer (out of office), 2017-02-28 15:38:17]

Description was changed from

==========
[heap] Use a separate concurrent store buffer processing flag.

BUG=
==========

to

==========
[heap] Use a separate concurrent store buffer processing flag.

BUG=chromium:697049
==========

[Hannes Payer (out of office), 2017-02-28 15:43:36]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-02-28 15:43:37]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2723473002/#ps20001
(title: "format")

[commit-bot: I haz the power, 2017-02-28 15:43:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 16:11:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488296616797660,
"parent_rev": "bfa425cc0841f17294e933e8d3611aad42deb2ee", "commit_rev":
"d05dede4cef58a1abfe3b733476f75fdea7fadda"}

[commit-bot: I haz the power, 2017-02-28 16:11:47]

Description was changed from

==========
[heap] Use a separate concurrent store buffer processing flag.

BUG=chromium:697049
==========

to

==========
[heap] Use a separate concurrent store buffer processing flag.

BUG=chromium:697049

Review-Url: https://codereview.chromium.org/2723473002
Cr-Commit-Position: refs/heads/master@{#43492}
Committed:
https://chromium.googlesource.com/v8/v8/+/d05dede4cef58a1abfe3b733476f75fdea7...
==========

[commit-bot: I haz the power, 2017-02-28 16:11:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d05dede4cef58a1abfe3b733476f75fdea7...

[Hannes Payer (out of office), 2017-02-28 21:23:55]

https://codereview.chromium.org/2723473002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):

https://codereview.chromium.org/2723473002/diff/1/src/flag-definitions.h#newc...
src/flag-definitions.h:1251: DEFINE_NEG_IMPLICATION(single_threaded,
parallel_compaction)
On 2017/02/27 10:51:00, ulan wrote:
> Please add:
> DEFINE_NEG_IMPLICATION(single_threaded, concurrent_store_buffer)

Thanks. Done.