ios/clean/chrome/browser/ui/tab_grid/tab_grid_collection_view_layout.mm - Issue 2723453003: [ios] Improve toolbar in tab_grid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/tab_grid/tab_grid_collection_view_layout.mm

Issue 2723453003: [ios] Improve toolbar in tab_grid (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/tab_grid/BUILD.gn ('k') | ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.h » ('j') | ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/clean/chrome/browser/ui/tab_grid/tab_grid_collection_view_layout.mm

diff --git a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_collection_view_layout.mm b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_collection_view_layout.mm

index 3810646144ee3e1047b5ba7e3299c2f504c9f1f8..39743840a16191723e5ed7ee3b28bd7f0a20e463 100644

--- a/ios/clean/chrome/browser/ui/tab_grid/tab_grid_collection_view_layout.mm

+++ b/ios/clean/chrome/browser/ui/tab_grid/tab_grid_collection_view_layout.mm

@@ -12,7 +12,7 @@ namespace {

const CGFloat kMinTabWidth = 200.0f;

const CGFloat kMaxTabWidth = 250.0f;

const CGFloat kInterTabSpacing = 20.0f;

-const UIEdgeInsets kSectionInset = {20.0f, 20.0f, 20.0f, 20.0f};

+const UIEdgeInsets kSectionInset = {10.0f, 20.0f, 20.0f, 20.0f};

marq (ping after 24h) 2017/03/02 06:04:54 Nit: Prefer not to use static struct assignment to

edchin 2017/03/02 07:12:43 Will do.

edchin 2017/03/16 07:19:59 Done.

}

@implementation TabGridCollectionViewLayout