MD Settings: Internet details: Fix proxy toggle and polish

MD Settings: Internet details: Fix proxy toggle and polish

This CL:
* Moves the 'Use same proxy for all protocols' into a separate settings-box and removes the custom formatting
* Uses more standard vars for spacing

BUG=698008
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2723403004
Cr-Commit-Position: refs/heads/master@{#454931}
Committed: https://chromium.googlesource.com/chromium/src/+/4fcf5f1ca0a74ac656f3db33c9073c8b4e4dd7fc

[stevenjb, 2017-03-02 23:19:16]

Description was changed from

==========
MD Settings: Internet details: Fix proxy toggle and polish

BUG=698008
==========

to

==========
MD Settings: Internet details: Fix proxy toggle and polish

BUG=698008
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-03-02 23:32:35]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2017-03-02 23:42:23]

Description was changed from

==========
MD Settings: Internet details: Fix proxy toggle and polish

BUG=698008
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet details: Fix proxy toggle and polish

This CL:
* Moves the 'Use same proxy for all protocols' into a separate settings-box and
removes the custom formatting
* Uses more standard vars for spacing

BUG=698008
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-03-03 23:36:16]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-03-04 02:25:56]

lgtm

https://codereview.chromium.org/2723403004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_proxy.html (right):

https://codereview.chromium.org/2723403004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.html:135:
hidden$="[[!matches_(proxy_.Type, ProxySettingsType_.MANUAL)]]">
every time i see a hidden$= instead of a dom-if, and angel loses its wings

https://codereview.chromium.org/2723403004/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
(right):

https://codereview.chromium.org/2723403004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html:20:
<iron-icon id="indicator" tabindex="0" aria-describedby="tooltip"
this is gonna eventually need an aria-label as well, like I'm doing here:
https://codereview.chromium.org/2720413002/

[stevenjb, 2017-03-06 18:33:49]

https://codereview.chromium.org/2723403004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/internet_page/network_proxy.html (right):

https://codereview.chromium.org/2723403004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/internet_page/network_proxy.html:135:
hidden$="[[!matches_(proxy_.Type, ProxySettingsType_.MANUAL)]]">
On 2017/03/04 02:25:55, Dan Beam wrote:
> every time i see a hidden$= instead of a dom-if, and angel loses its wings

If it helps you feel better, all of network-proxy is inside a dom-if :)

FWIW, I have a mental to-do to selectively replace hidden$ with dom-if
throughout Internet (which predates our use of dom-if), but will do so
separately (and it's not super high priority). I think we want to un-inline this
UI at the same time. I've introduced bugs by switching from hidden$ without
carefully auditing the JS (e.g. $. may not work, and properties need default
values).

https://codereview.chromium.org/2723403004/diff/20001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
(right):

https://codereview.chromium.org/2723403004/diff/20001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html:20:
<iron-icon id="indicator" tabindex="0" aria-describedby="tooltip"
On 2017/03/04 02:25:55, Dan Beam wrote:
> this is gonna eventually need an aria-label as well, like I'm doing here:
> https://codereview.chromium.org/2720413002/

I don't quite follow; commented on the tissue. I will follow up when both of
these land to at least make this consistent with the pref indicator.

[stevenjb, 2017-03-06 18:35:37]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-03-06 18:35:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2723403004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-06 18:35:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2017-03-06 19:12:22]

lgtm

[commit-bot: I haz the power, 2017-03-06 20:09:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488825337185900,
"parent_rev": "9c0d0b5e98c897cf7d51069c10e2fc23e1fc89aa", "commit_rev":
"4fcf5f1ca0a74ac656f3db33c9073c8b4e4dd7fc"}

[commit-bot: I haz the power, 2017-03-06 20:10:16]

Description was changed from

==========
MD Settings: Internet details: Fix proxy toggle and polish

This CL:
* Moves the 'Use same proxy for all protocols' into a separate settings-box and
removes the custom formatting
* Uses more standard vars for spacing

BUG=698008
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Internet details: Fix proxy toggle and polish

This CL:
* Moves the 'Use same proxy for all protocols' into a separate settings-box and
removes the custom formatting
* Uses more standard vars for spacing

BUG=698008
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2723403004
Cr-Commit-Position: refs/heads/master@{#454931}
Committed:
https://chromium.googlesource.com/chromium/src/+/4fcf5f1ca0a74ac656f3db33c907...
==========

[commit-bot: I haz the power, 2017-03-06 20:10:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4fcf5f1ca0a74ac656f3db33c907...