gpu: Replace GpuMsg_Finalize ipc with equivalent mojom api

gpu: Replace GpuMsg_Finalize ipc with equivalent mojom api

Remove GpuMsg_Finalize, and associated code (e.g.
GpuProcessHost*::StopGpuProcess()). Introduce GpuService::Stop() mojom
api in its place, and content::StopGpuProcess() so that content embedders
(e.g. chromecast) can stop the gpu process when desired.

BUG=639941, 643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2723363002
Cr-Commit-Position: refs/heads/master@{#456242}
Committed: https://chromium.googlesource.com/chromium/src/+/e6f6e1048099d2ce82e0b5d70d69206f5f3077fe

[sadrul, 2017-03-02 02:37:28]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 02:38:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-03-02 02:39:18]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-03-02 02:39:19]

Unfortunately, it is. I tried doing this too 6 months ago:
https://codereview.chromium.org/2267843002/

[sadrul, 2017-03-02 03:28:50]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2017-03-02 03:29:18]

Description was changed from

==========
gpu: Remove GpuMsg_Finalize ipc since it's never actually used.

GpuProcessHost*::StopGpuProcess() is never actually called. So just
remove these and the GpuMsg_Finalize ipc.

BUG=none
==========

to

==========
gpu: Remove GpuMsg_Finalize ipc since it's never actually used.

GpuProcessHost*::StopGpuProcess() is never actually called. So just
remove these and the GpuMsg_Finalize ipc.

GpuProcessHost::ForceShutdown() should be equivalent code. So chromecast
(which in internal code does use StopGpuProcess()) can use that instead.

BUG=none
==========

[commit-bot: I haz the power, 2017-03-02 03:29:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-02 03:31:58]

On 2017/03/02 02:39:19, Fady Samuel wrote:
> Unfortunately, it is. I tried doing this too 6 months ago:
> https://codereview.chromium.org/2267843002/

drat. Thanks for letting me know.

Looking at the code, it looks like calling GpuProcessHost::ForceShutdown() would
be equivalent. (both terminate th

[sadrul, 2017-03-02 03:31:59]

On 2017/03/02 02:39:19, Fady Samuel wrote:
> Unfortunately, it is. I tried doing this too 6 months ago:
> https://codereview.chromium.org/2267843002/

drat. Thanks for letting me know.

Looking at the code, it looks like calling GpuProcessHost::ForceShutdown() would
be equivalent. (both terminate th

[sadrul, 2017-03-02 03:32:47]

On 2017/03/02 02:39:19, Fady Samuel wrote:
> Unfortunately, it is. I tried doing this too 6 months ago:
> https://codereview.chromium.org/2267843002/

drat. Thanks for letting me know.

Looking at the code, it looks like calling GpuProcessHost::ForceShutdown() would
be equivalent. (both terminate the MessageLoop of the main-thread). So it should
be possible for chromecast to start using that instead.

[Fady Samuel, 2017-03-02 03:41:07]

On 2017/03/02 03:32:47, sadrul wrote:
> On 2017/03/02 02:39:19, Fady Samuel wrote:
> > Unfortunately, it is. I tried doing this too 6 months ago:
> > https://codereview.chromium.org/2267843002/
> 
> drat. Thanks for letting me know.
> 
> Looking at the code, it looks like calling GpuProcessHost::ForceShutdown()
would
> be equivalent. (both terminate the MessageLoop of the main-thread). So it
should
> be possible for chromecast to start using that instead.

Cool. Probably want to get in touch with someone working on Chromecast first
before making that change though.

[sadrul, 2017-03-02 03:42:26]

On 2017/03/02 03:41:07, Fady Samuel wrote:
> On 2017/03/02 03:32:47, sadrul wrote:
> > On 2017/03/02 02:39:19, Fady Samuel wrote:
> > > Unfortunately, it is. I tried doing this too 6 months ago:
> > > https://codereview.chromium.org/2267843002/
> > 
> > drat. Thanks for letting me know.
> > 
> > Looking at the code, it looks like calling GpuProcessHost::ForceShutdown()
> would
> > be equivalent. (both terminate the MessageLoop of the main-thread). So it
> should
> > be possible for chromecast to start using that instead.
> 
> Cool. Probably want to get in touch with someone working on Chromecast first
> before making that change though.

Yes, left a comment on the bug.

[sadrul, 2017-03-02 03:42:51]

Description was changed from

==========
gpu: Remove GpuMsg_Finalize ipc since it's never actually used.

GpuProcessHost*::StopGpuProcess() is never actually called. So just
remove these and the GpuMsg_Finalize ipc.

GpuProcessHost::ForceShutdown() should be equivalent code. So chromecast
(which in internal code does use StopGpuProcess()) can use that instead.

BUG=none
==========

to

==========
gpu: Remove GpuMsg_Finalize ipc since it's never actually used.

GpuProcessHost*::StopGpuProcess() is never actually called. So just
remove these and the GpuMsg_Finalize ipc.

GpuProcessHost::ForceShutdown() should be equivalent code. So chromecast
(which in internal code does use StopGpuProcess()) can use that instead.

BUG=639941
==========

[commit-bot: I haz the power, 2017-03-02 07:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 07:28:00]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sadrul, 2017-03-09 21:09:50]

Description was changed from

==========
gpu: Remove GpuMsg_Finalize ipc since it's never actually used.

GpuProcessHost*::StopGpuProcess() is never actually called. So just
remove these and the GpuMsg_Finalize ipc.

GpuProcessHost::ForceShutdown() should be equivalent code. So chromecast
(which in internal code does use StopGpuProcess()) can use that instead.

BUG=639941
==========

to

==========
gpu: Remove GpuMsg_Finalize ipc since it's never actually used.

GpuProcessHost*::StopGpuProcess() is never actually called. So just
remove these and the GpuMsg_Finalize ipc.

GpuProcessHost::ForceShutdown() should be equivalent code. So chromecast
(which in internal code does use StopGpuProcess()) can use that instead.

BUG=639941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[sadrul, 2017-03-09 21:09:53]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 21:10:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-09 21:34:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 21:35:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-09 21:47:09]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 21:47:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 22:37:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 22:37:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-03-10 02:14:15]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-10 02:14:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:57:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 02:57:25]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-10 03:11:00]

Description was changed from

==========
gpu: Remove GpuMsg_Finalize ipc since it's never actually used.

GpuProcessHost*::StopGpuProcess() is never actually called. So just
remove these and the GpuMsg_Finalize ipc.

GpuProcessHost::ForceShutdown() should be equivalent code. So chromecast
(which in internal code does use StopGpuProcess()) can use that instead.

BUG=639941
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
gpu: Replace GpuMsg_Finalize ipc with equivalent mojom api

Remove GpuMsg_Finalize, and associated code (e.g.
GpuProcessHost*::StopGpuProcess()). Introduce GpuService::Stop() mojom
api in its place, and content::StopGpuProcess() so that content embedders
(e.g. chromecast) can stop the gpu process when desired.

BUG=639941, 643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[sadrul, 2017-03-10 03:14:37]

sadrul@chromium.org changed reviewers:
+ piman@chromium.org

[sadrul, 2017-03-10 03:14:38]

+piman@ As suggested in the bug [1], updated this CL to replace the
GpuMsg_Finalize with a mojom API, with a test demonstrating its use.

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=639941#c6

[sadrul, 2017-03-10 03:16:52]

/cc+ halliwell@ fyi

[halliwell, 2017-03-10 03:45:16]

On 2017/03/10 03:16:52, sadrul wrote:
> /cc+ halliwell@ fyi

Thank you for this :D

[piman, 2017-03-10 18:22:50]

lgtm

[sadrul, 2017-03-10 18:28:45]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:29:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 18:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:37:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2017-03-10 18:48:46]

sadrul@chromium.org changed reviewers:
+ tsepez@chromium.org

[sadrul, 2017-03-10 18:48:47]

+tsepez@ for ipc (mojom and messages)

[Tom Sepez, 2017-03-10 20:47:59]

lgtm

[sadrul, 2017-03-11 01:04:24]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-03-11 01:04:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 01:10:00]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489194264289770,
"parent_rev": "d1e0d77cda61c166a2e01a856419e9cb7c93fdea", "commit_rev":
"e6f6e1048099d2ce82e0b5d70d69206f5f3077fe"}

[commit-bot: I haz the power, 2017-03-11 01:11:28]

Description was changed from

==========
gpu: Replace GpuMsg_Finalize ipc with equivalent mojom api

Remove GpuMsg_Finalize, and associated code (e.g.
GpuProcessHost*::StopGpuProcess()). Introduce GpuService::Stop() mojom
api in its place, and content::StopGpuProcess() so that content embedders
(e.g. chromecast) can stop the gpu process when desired.

BUG=639941, 643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
gpu: Replace GpuMsg_Finalize ipc with equivalent mojom api

Remove GpuMsg_Finalize, and associated code (e.g.
GpuProcessHost*::StopGpuProcess()). Introduce GpuService::Stop() mojom
api in its place, and content::StopGpuProcess() so that content embedders
(e.g. chromecast) can stop the gpu process when desired.

BUG=639941, 643746
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2723363002
Cr-Commit-Position: refs/heads/master@{#456242}
Committed:
https://chromium.googlesource.com/chromium/src/+/e6f6e1048099d2ce82e0b5d70d69...
==========

[commit-bot: I haz the power, 2017-03-11 01:11:29]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/e6f6e1048099d2ce82e0b5d70d69...