Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2723323002: Update media canPlayType() tests to be spec-compliant (Closed)

Created:
3 years, 9 months ago by jrummell
Modified:
3 years, 9 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, blink-reviews, feature-media-reviews_chromium.org, Srirama, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update media canPlayType() tests to be spec-compliant RFC6381 (MIME Codecs and Profiles) specifies that a list of codecs must be enclosed within double quotes. Updating the canPlayType() tests to do that. BUG=697241 TEST=updated tests pass Review-Url: https://codereview.chromium.org/2723323002 Cr-Commit-Position: refs/heads/master@{#454353} Committed: https://chromium.googlesource.com/chromium/src/+/4ed1f13bda118c1ca19f8ddb649ba165ff6969d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M third_party/WebKit/LayoutTests/media/media-can-play-ogg.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/media-can-play-webm.html View 1 chunk +19 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
jrummell
PTAL.
3 years, 9 months ago (2017-03-02 00:03:23 UTC) #2
chcunningham
LGTM. Thanks John!
3 years, 9 months ago (2017-03-02 01:33:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723323002/1
3 years, 9 months ago (2017-03-02 18:35:22 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 19:55:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ed1f13bda118c1ca19f8ddb649b...

Powered by Google App Engine
This is Rietveld 408576698