components/arc/net/arc_net_host_impl.cc - Issue 2723263003: arc: Provide more logging for network failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/net/arc_net_host_impl.cc

Issue 2723263003: arc: Provide more logging for network failures. (Closed)

Patch Set: forgot to clean arc_auth_service.cc Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/net/arc_net_host_impl.cc

diff --git a/components/arc/net/arc_net_host_impl.cc b/components/arc/net/arc_net_host_impl.cc

index 995e28526d8243e2958972ea285ef5d05ed5b44f..b6f497d0b1902e9d9fb5863bf5c1a9ddbbb7af7c 100644

--- a/components/arc/net/arc_net_host_impl.cc

+++ b/components/arc/net/arc_net_host_impl.cc

@@ -55,7 +55,7 @@ std::string GetStringFromOncDictionary(const base::DictionaryValue* dict,

std::string value;

dict->GetString(key, &value);

if (required && value.empty())

- NOTREACHED();

+ VLOG(1) << "Required parameter " << key << " was not found.";

Luis Héctor Chávez 2017/03/01 23:17:09 maybe NOTREACHED() << ... ?

return value;

}