arc: Provide more logging for network failures.

components/arc/net/arc_net_host_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/net/arc_net_host_impl.h"
 
 #include <string>
 #include <utility>
 #include <vector>
 
@@ skipping 37 matching lines @@
   return chromeos::LoginState::Get()->GetLoggedInUserType() ==
          chromeos::LoginState::LOGGED_IN_USER_OWNER;
 }
 
 std::string GetStringFromOncDictionary(const base::DictionaryValue* dict,
                                        const char* key,
                                        bool required) {
   std::string value;
   dict->GetString(key, &value);
   if (required && value.empty())
-    NOTREACHED();
+    VLOG(1) << "Required parameter " << key << " was not found.";

[Luis Héctor Chávez, 2017/03/01 23:17:09]

maybe NOTREACHED() << ... ?

   return value;
 }
 
 arc::mojom::SecurityType TranslateONCWifiSecurityType(
     const base::DictionaryValue* dict) {
   std::string type = GetStringFromOncDictionary(dict, onc::wifi::kSecurity,
                                                 true /* required */);
   if (type == onc::wifi::kWEP_PSK)
     return arc::mojom::SecurityType::WEP_PSK;
   else if (type == onc::wifi::kWEP_8021X)
@@ skipping 585 matching lines @@
   net_instance->WifiEnabledStateChanged(is_enabled);
 }
 
 void ArcNetHostImpl::OnShuttingDown() {
   DCHECK(observing_network_state_);
   GetStateHandler()->RemoveObserver(this, FROM_HERE);
   observing_network_state_ = false;
 }
 
 }  // namespace arc