build/config/clang/BUILD.gn - Issue 2723253003: build: Enable auto raw pointer deduction check everywhere on clang.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/clang/BUILD.gn

Issue 2723253003: build: Enable auto raw pointer deduction check everywhere on clang. (Closed)

Patch Set: update Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/clang/BUILD.gn

diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn

index 22e308f330a9432e8521428cb69a105788fe2837..0aeccd07da180ca83b12dc997898185a7e9919b2 100644

--- a/build/config/clang/BUILD.gn

+++ b/build/config/clang/BUILD.gn

@@ -35,18 +35,12 @@ config("find_bad_constructs") {

"-add-plugin",

"-Xclang",

"find-bad-constructs",

+ "-Xclang",

+ "-plugin-arg-find-bad-constructs",

+ "-Xclang",

+ "check-auto-raw-pointer",

]

- # TODO(vmpstr): We need to enable this everywhere. crbug.com/554600

- if (is_linux && !is_chromeos && !is_chromecast) {

- cflags += [

- "-Xclang",

- "-plugin-arg-find-bad-constructs",

- "-Xclang",

- "check-auto-raw-pointer",

- ]

- }

if ((is_linux || is_android) && !is_chromecast) {

cflags += [

"-Xclang",

« no previous file with comments | « no previous file | ios/chrome/browser/tabs/tab.mm » ('j') | no next file with comments »