Do not enforce origin length and stream id requirement for ALTSVC frames.

Do not enforce origin length and stream id requirement for ALTSVC frames.

Remove this check from Http2FrameDecoderAdapter, which is part of the
new gfe/http2/ HTTP/2 frame decoder implementation.  This makes sense,
as SpdyFramer, the currently used HTTP/2 frame decoder, does not enforce
this requirement either.

Http2FrameDecoderAdapter incorrectly signals an error on invalid ALTSVC frames,
whereas RFC7838 states that they MUST be ignored.  This makes
AltSvcFrameTest.DoNotProcessAltSvcFrameWithEmptyOriginOnStreamZero and
AltSvcFrameTest.DoNotProcessAltSvcFrameWithNonEmptyOriginOnNonZeroStream
fail with FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter
set, effectively blocking the launch of that flag.  This CL fixes that.

This CL lands server change 148893483 by bnc.

BUG=488484, 696653
Review-Url: https://codereview.chromium.org/2723203002
Cr-Commit-Position: refs/heads/master@{#454009}
Committed: https://chromium.googlesource.com/chromium/src/+/62f6a594d8fd10ed15019c9c8e4369d8477355af

[Bence, 2017-03-01 18:00:05]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 18:00:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-03-01 19:09:09]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2017-03-01 19:09:10]

Ryan: PTAL.  Thank you.

[commit-bot: I haz the power, 2017-03-01 19:10:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 19:10:20]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-03-01 19:36:08]

lgtm

[Bence, 2017-03-01 19:59:09]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2017-03-01 19:59:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 20:12:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488398349294310, "parent_rev":
"6470341429052985f7e031e623f407dcf1538f09", "commit_rev":
"62f6a594d8fd10ed15019c9c8e4369d8477355af"}

[commit-bot: I haz the power, 2017-03-01 20:13:44]

Description was changed from

==========
Do not enforce origin length and stream id requirement for ALTSVC frames.

Remove this check from Http2FrameDecoderAdapter, which is part of the
new gfe/http2/ HTTP/2 frame decoder implementation.  This makes sense,
as SpdyFramer, the currently used HTTP/2 frame decoder, does not enforce
this requirement either.

Http2FrameDecoderAdapter incorrectly signals an error on invalid ALTSVC frames,
whereas RFC7838 states that they MUST be ignored.  This makes
AltSvcFrameTest.DoNotProcessAltSvcFrameWithEmptyOriginOnStreamZero and
AltSvcFrameTest.DoNotProcessAltSvcFrameWithNonEmptyOriginOnNonZeroStream
fail with FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter
set, effectively blocking the launch of that flag.  This CL fixes that.

This CL lands server change 148893483 by bnc.

BUG=488484, 696653
==========

to

==========
Do not enforce origin length and stream id requirement for ALTSVC frames.

Remove this check from Http2FrameDecoderAdapter, which is part of the
new gfe/http2/ HTTP/2 frame decoder implementation.  This makes sense,
as SpdyFramer, the currently used HTTP/2 frame decoder, does not enforce
this requirement either.

Http2FrameDecoderAdapter incorrectly signals an error on invalid ALTSVC frames,
whereas RFC7838 states that they MUST be ignored.  This makes
AltSvcFrameTest.DoNotProcessAltSvcFrameWithEmptyOriginOnStreamZero and
AltSvcFrameTest.DoNotProcessAltSvcFrameWithNonEmptyOriginOnNonZeroStream
fail with FLAGS_chromium_http2_flag_spdy_use_http2_frame_decoder_adapter
set, effectively blocking the launch of that flag.  This CL fixes that.

This CL lands server change 148893483 by bnc.

BUG=488484, 696653

Review-Url: https://codereview.chromium.org/2723203002
Cr-Commit-Position: refs/heads/master@{#454009}
Committed:
https://chromium.googlesource.com/chromium/src/+/62f6a594d8fd10ed15019c9c8e43...
==========

[commit-bot: I haz the power, 2017-03-01 20:13:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/62f6a594d8fd10ed15019c9c8e43...