Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2723183002: Deprecate IDBFactory webkitGetDatabaseNames() (Closed)

Created:
3 years, 9 months ago by jsbell
Modified:
3 years, 9 months ago
CC:
chromium-reviews, cmumford, haraken, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-frames_chromium.org, jsbell+idb_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate IDBFactory webkitGetDatabaseNames() Deprecation warning on the console, alerting to planned removal in M60. BUG=696010 Review-Url: https://codereview.chromium.org/2723183002 Cr-Commit-Position: refs/heads/master@{#454237} Committed: https://chromium.googlesource.com/chromium/src/+/af5e96b26ca62a309ee81a943721367a52b6741a

Patch Set 1 #

Patch Set 2 : Re-use existing enum member #

Patch Set 3 : Test expectation updates #

Messages

Total messages: 20 (15 generated)
jsbell
foolip@ or rbyers@ - can you review?
3 years, 9 months ago (2017-03-01 19:56:29 UTC) #6
foolip
lgtm
3 years, 9 months ago (2017-03-02 12:32:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723183002/40001
3 years, 9 months ago (2017-03-02 12:32:38 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/af5e96b26ca62a309ee81a943721367a52b6741a
3 years, 9 months ago (2017-03-02 12:37:01 UTC) #18
Charlie Reis
3 years, 9 months ago (2017-03-02 17:40:46 UTC) #20
Message was sent while issue was closed.
This CL is causing the Site Isolation Linux FYI bot to fail with a text diff on
cross-origin-indexeddb-allowed.html and
cross-origin-worker-indexeddb-allowed.html:

https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/b...

Do you know why it would produce different output when run with
--site-per-process?  (I'll file a bug to track it.)

Powered by Google App Engine
This is Rietveld 408576698