Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2723103003: chromeos: Fold ash/common/test/BUILD.gn into ash/test/BUILD.gn (Closed)

Created:
3 years, 9 months ago by James Cook
Modified:
3 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Fold ash/common/test/BUILD.gn into ash/test/BUILD.gn This is preparation for moving all the files out of //ash/common into //ash. I'm collapsing all the BUILD.gn files first so the move can be entirely mechanical. BUG=690096 TEST=compiles, ash_unittests, ash_content_unittests Review-Url: https://codereview.chromium.org/2723103003 Cr-Commit-Position: refs/heads/master@{#454185} Committed: https://chromium.googlesource.com/chromium/src/+/7e20e35dace024a8291ed7cd88e23b827c5f55e1

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -53 lines) Patch
M ash/BUILD.gn View 1 4 chunks +0 lines, -4 lines 0 comments Download
D ash/common/test/BUILD.gn View 1 1 chunk +0 lines, -46 lines 0 comments Download
M ash/mus/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/BUILD.gn View 1 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
James Cook
sky, please take a look.
3 years, 9 months ago (2017-03-01 22:42:16 UTC) #4
sky
LGTM
3 years, 9 months ago (2017-03-02 03:11:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723103003/20001
3 years, 9 months ago (2017-03-02 03:14:25 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 05:28:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7e20e35dace024a8291ed7cd88e2...

Powered by Google App Engine
This is Rietveld 408576698