Rename LRU Input Method to Last Input Method

Rename LRU Input Method to Last Input Method

Change the naming of last input methods stored for users from LRU to
Last, because LRU is confusing in this context as it suggest that the
least recently used input method is stored.

BUG=697423
TEST=browser_tests --gtest_filter=LoginUIKeyboard*

Review-Url: https://codereview.chromium.org/2723083003
Cr-Commit-Position: refs/heads/master@{#454580}
Committed: https://chromium.googlesource.com/chromium/src/+/90fcce75b3610cad4332d51460504dc3f015abc7

[pmarko, 2017-03-01 15:01:35]

pmarko@chromium.org changed reviewers:
+ alemate@chromium.org

[pmarko, 2017-03-01 15:01:36]

Hi Alexander,

please take a look at the proposed renaming of LRU -> Last before I submit it
for further review.
Thanks!

[Alexander Alekseev, 2017-03-01 22:00:45]

lgtm

[pmarko, 2017-03-02 08:43:17]

pmarko@chromium.org changed reviewers:
+ pastarmovj@chromium.org, shuchen@chromium.org

[pmarko, 2017-03-02 08:43:18]

pastarmovj@chromium.org: Please review changes in policy_templates.json

shuchen@chromium.org: Please review changes in input_method_persistence.

[pastarmovj, 2017-03-02 12:13:00]

lgtm

[Shu Chen, 2017-03-03 11:11:39]

lgtm

[pmarko, 2017-03-03 11:58:00]

The CQ bit was checked by pmarko@chromium.org

[commit-bot: I haz the power, 2017-03-03 11:58:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 13:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 13:14:41]

Failed to apply patch for
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h:234
  error: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h: patch
does not apply

Patch:       chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
Index: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
diff --git a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
index
b174e1d777223390a70fb8299c6bbaf7f000e569..1d7f6ad676d57c21be3c3a1640101ce95dff184c
100644
--- a/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
+++ b/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
@@ -234,10 +234,10 @@ class SigninScreenHandler
       GaiaScreenHandler* gaia_screen_handler);
   ~SigninScreenHandler() override;
 
-  static std::string GetUserLRUInputMethod(const std::string& username);
+  static std::string GetUserLastInputMethod(const std::string& username);
 
   // Update current input method (namely keyboard layout) in the given IME
state
-  // to LRU by this user.
+  // to last input method used by this user.
   static void SetUserInputMethod(
       const std::string& username,
       input_method::InputMethodManager::State* ime_state);

[pmarko, 2017-03-03 14:07:58]

The CQ bit was checked by pmarko@chromium.org

[pmarko, 2017-03-03 14:07:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
alemate@chromium.org, shuchen@chromium.org, pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2723083003/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-03 14:08:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 14:56:43]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488550078604130,
"parent_rev": "cec451003f8252189fea6bd053f53ff24d1a583d", "commit_rev":
"90fcce75b3610cad4332d51460504dc3f015abc7"}

[commit-bot: I haz the power, 2017-03-03 14:57:24]

Description was changed from

==========
Rename LRU Input Method to Last Input Method

Change the naming of last input methods stored for users from LRU to
Last, because LRU is confusing in this context as it suggest that the
least recently used input method is stored.

BUG=697423
TEST=browser_tests --gtest_filter=LoginUIKeyboard*
==========

to

==========
Rename LRU Input Method to Last Input Method

Change the naming of last input methods stored for users from LRU to
Last, because LRU is confusing in this context as it suggest that the
least recently used input method is stored.

BUG=697423
TEST=browser_tests --gtest_filter=LoginUIKeyboard*

Review-Url: https://codereview.chromium.org/2723083003
Cr-Commit-Position: refs/heads/master@{#454580}
Committed:
https://chromium.googlesource.com/chromium/src/+/90fcce75b3610cad4332d5146050...
==========

[commit-bot: I haz the power, 2017-03-03 14:57:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/90fcce75b3610cad4332d5146050...