Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2723083003: Rename LRU Input Method to Last Input Method (Closed)

Created:
3 years, 9 months ago by pmarko
Modified:
3 years, 9 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, achuith+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, tnagel+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename LRU Input Method to Last Input Method Change the naming of last input methods stored for users from LRU to Last, because LRU is confusing in this context as it suggest that the least recently used input method is stored. BUG=697423 TEST=browser_tests --gtest_filter=LoginUIKeyboard* Review-Url: https://codereview.chromium.org/2723083003 Cr-Commit-Position: refs/heads/master@{#454580} Committed: https://chromium.googlesource.com/chromium/src/+/90fcce75b3610cad4332d51460504dc3f015abc7

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -64 lines) Patch
M chrome/browser/chromeos/input_method/input_method_persistence.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence.cc View 4 chunks +27 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 5 chunks +18 lines, -18 lines 0 comments Download
M chrome/common/pref_names.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
pmarko
Hi Alexander, please take a look at the proposed renaming of LRU -> Last before ...
3 years, 9 months ago (2017-03-01 15:01:36 UTC) #2
Alexander Alekseev
lgtm
3 years, 9 months ago (2017-03-01 22:00:45 UTC) #3
pmarko
pastarmovj@chromium.org: Please review changes in policy_templates.json shuchen@chromium.org: Please review changes in input_method_persistence.
3 years, 9 months ago (2017-03-02 08:43:18 UTC) #5
pastarmovj
lgtm
3 years, 9 months ago (2017-03-02 12:13:00 UTC) #6
Shu Chen
lgtm
3 years, 9 months ago (2017-03-03 11:11:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723083003/1
3 years, 9 months ago (2017-03-03 11:58:12 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-03 13:14:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723083003/20001
3 years, 9 months ago (2017-03-03 14:08:18 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 14:57:25 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/90fcce75b3610cad4332d5146050...

Powered by Google App Engine
This is Rietveld 408576698