Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2723083002: RenderFrameImpl: avoid creating many temporary WebDocuments. (Closed)

Created:
3 years, 9 months ago by sof
Modified:
3 years, 9 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RenderFrameImpl: avoid creating many temporary WebDocuments. Accessing a property off of a WebFrame's document will entail instantiating a WebDocument, which implies a WebPrivatePtr<> holding a persistent reference. Avoid the overhead via some manual CSEing. R=esprehn,jochen BUG= Review-Url: https://codereview.chromium.org/2723083002 Cr-Commit-Position: refs/heads/master@{#454878} Committed: https://chromium.googlesource.com/chromium/src/+/ad341188a500e8641b96f48ab644a691912f982e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M content/renderer/render_frame_impl.cc View 4 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
sof
please take a look. while examining Persistent<> allocation patterns, I noticed we're churning through 4-5 ...
3 years, 9 months ago (2017-03-01 12:43:26 UTC) #4
esprehn
lgtm, but someone will likely refactor this the other way eventually. We should work on ...
3 years, 9 months ago (2017-03-03 21:51:21 UTC) #7
esprehn
Actually doesn't allocatePersistentNode and freePersistentNode have a free list where we'd reuse the same Persistent ...
3 years, 9 months ago (2017-03-03 21:59:01 UTC) #8
sof
On 2017/03/03 21:59:01, esprehn wrote: > Actually doesn't allocatePersistentNode and freePersistentNode have a free list ...
3 years, 9 months ago (2017-03-03 22:04:55 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 9 months ago (2017-03-06 12:51:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723083002/1
3 years, 9 months ago (2017-03-06 16:17:00 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 17:04:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad341188a500e8641b96f48ab644...

Powered by Google App Engine
This is Rietveld 408576698