Use the correct case converter for |localName| and |tagName|

Use the correct case converter for |localName| and |tagName|

Per spec[1], document.createElement should set |localName|
to ASCII lowercase when context object is an HTML document.

Now the AtomicString::lower() was used,
but it converts characters more than ASCII into lowercase.
So we should use AtomicString::lowerASCII() instead.

Besides, per spec[2], Element.tagName should be set to ASCII
uppercase when context object is in HTML namespace and its node
document is an HTML document.

Now we are using (Atomic)String::upper() due to lack of
ASCII uppercase support. So (Atomic)String::upperASCII() is
added to solve this issue, and AtomicString::upper() is removed
since it's not used anymore.

Tests were changed accordingly

[1]: https://dom.spec.whatwg.org/#dom-document-createelement
[2]: https://dom.spec.whatwg.org/#dom-element-tagname

BUG=685012
Review-Url: https://codereview.chromium.org/2723053002
Cr-Commit-Position: refs/heads/master@{#454059}
Committed: https://chromium.googlesource.com/chromium/src/+/1337a0b763dc552f6eeadb17df348429b34a3501

[Sunny, 2017-03-01 08:56:36]

ratsunny@gmail.com changed reviewers:
+ tkent@chromium.org

[Sunny, 2017-03-01 08:56:37]

Hi tkent@, I got
`** Presubmit ERRORS **
check-webkit-style failed
  third_party/WebKit/Source/wtf/text/StringImpl.h:384:  Local variables should
never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). 
[readability/pass_ptr] [5]
`
when uploading the patch. Since many APIs in StringImpl.h use
`PassRefPtr<StringImpl>` as return value, can I still use it and will
--bypass-hooks cause commit issue?

[Sunny, 2017-03-01 08:59:25]

https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/AtomicString.h (right):

https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/AtomicString.h:174: AtomicString upperASCII()
const { return AtomicString(impl()->upperASCII()); }
Hi tkent, I'm not sure call impl() here will return nullptr or not but I saw
line 169 use it directly, can I use it directly?

[tkent, 2017-03-01 09:20:11]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 09:20:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 10:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 10:55:37]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-03-01 12:21:27]

Thank you for fixing it.

> check-webkit-style failed
>  third_party/WebKit/Source/wtf/text/StringImpl.h:384:  Local variables should
never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). 
[readability/pass_ptr] [5]
`
Looks a false alarm.  Let's ignore it by --bypass-hooks.
I think it won't prevent CQ.

https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLElement.cpp (right):

https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLElement.cpp:118: :
tagQName().localName().upper();
Let's use upperASCII() here for consistency.
I think debugNodeName() doesn't affect web-exposed behavior.

Then, maybe we can remove AtomicString::upper().

https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/AtomicString.h (right):

https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/AtomicString.h:174: AtomicString upperASCII()
const { return AtomicString(impl()->upperASCII()); }
On 2017/03/01 at 08:59:25, Sunny wrote:
> Hi tkent, I'm not sure call impl() here will return nullptr or not but I saw
line 169 use it directly, can I use it directly?

It should support null impl(). So implement it like AtomicString::lowerASCII().

https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/wtf/text/WTFString.h (right):

https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/wtf/text/WTFString.h:293: String upperASCII() const;
Please add a comment like AtomicString.h.

This function declaration should be put prior to lower() or posterior to
upper(const AtomicString&).

[Sunny, 2017-03-01 17:59:06]

Description was changed from

==========
Correct the case converter for |localName| and |tagName|

Per spec[1], document.createElement should set |localName|
to ASCII lowercase when context object is an HTML document.

Now we are using AtomicString::lower(),
but it converts characters more than ASCII into lowercase.
So use AtomicString::lowerASCII() instead.

Besides, per spec[2], Element.tagName should be set to ASCII
uppercase when context object is in HTML namespace and its node
document is an HTML document.

Now we are using (Atomic)String::upper() because lacking of
ASCII uppsercase support. So (Atomic)String::upperASCII() is
added to solve this issue.

Tests were changed accordingly

[1]: https://dom.spec.whatwg.org/#dom-document-createelement
[2]: https://dom.spec.whatwg.org/#dom-element-tagname

BUG=685012
==========

to

==========
Correct the case converter for |localName| and |tagName|

Per spec[1], document.createElement should set |localName|
to ASCII lowercase when context object is an HTML document.

Now we are using AtomicString::lower(),
but it converts characters more than ASCII into lowercase.
So use AtomicString::lowerASCII() instead.

Besides, per spec[2], Element.tagName should be set to ASCII
uppercase when context object is in HTML namespace and its node
document is an HTML document.

Now we are using (Atomic)String::upper() because lacking of
ASCII uppercase support. So (Atomic)String::upperASCII() is
added to solve this issue, and AtomicString::upper() is removed
since it's not used anymore.

Tests were changed accordingly

[1]: https://dom.spec.whatwg.org/#dom-document-createelement
[2]: https://dom.spec.whatwg.org/#dom-element-tagname

BUG=685012
==========

[Sunny, 2017-03-01 18:03:52]

On 2017/03/01 12:21:27, tkent wrote:
> Thank you for fixing it.
> 
> > check-webkit-style failed
> >  third_party/WebKit/Source/wtf/text/StringImpl.h:384:  Local variables
should
> never be PassRefPtr (see http://webkit.org/coding/RefPtr.html). 
> [readability/pass_ptr] [5]
> `
> Looks a false alarm.  Let's ignore it by --bypass-hooks.
> I think it won't prevent CQ.
> 
>
https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/html/HTMLElement.cpp (right):
> 
>
https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/html/HTMLElement.cpp:118: :
> tagQName().localName().upper();
> Let's use upperASCII() here for consistency.
> I think debugNodeName() doesn't affect web-exposed behavior.
> 
> Then, maybe we can remove AtomicString::upper().
> 
>
https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
> File third_party/WebKit/Source/wtf/text/AtomicString.h (right):
> 
>
https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
> third_party/WebKit/Source/wtf/text/AtomicString.h:174: AtomicString
upperASCII()
> const { return AtomicString(impl()->upperASCII()); }
> On 2017/03/01 at 08:59:25, Sunny wrote:
> > Hi tkent, I'm not sure call impl() here will return nullptr or not but I saw
> line 169 use it directly, can I use it directly?
> 
> It should support null impl(). So implement it like
AtomicString::lowerASCII().
> 
>
https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
> File third_party/WebKit/Source/wtf/text/WTFString.h (right):
> 
>
https://codereview.chromium.org/2723053002/diff/1/third_party/WebKit/Source/w...
> third_party/WebKit/Source/wtf/text/WTFString.h:293: String upperASCII() const;
> Please add a comment like AtomicString.h.
> 
> This function declaration should be put prior to lower() or posterior to
> upper(const AtomicString&).

Hi tkent@, I've updated the patch, PTAL again, thanks~

[Sunny, 2017-03-01 18:57:07]

Description was changed from

==========
Correct the case converter for |localName| and |tagName|

Per spec[1], document.createElement should set |localName|
to ASCII lowercase when context object is an HTML document.

Now we are using AtomicString::lower(),
but it converts characters more than ASCII into lowercase.
So use AtomicString::lowerASCII() instead.

Besides, per spec[2], Element.tagName should be set to ASCII
uppercase when context object is in HTML namespace and its node
document is an HTML document.

Now we are using (Atomic)String::upper() because lacking of
ASCII uppercase support. So (Atomic)String::upperASCII() is
added to solve this issue, and AtomicString::upper() is removed
since it's not used anymore.

Tests were changed accordingly

[1]: https://dom.spec.whatwg.org/#dom-document-createelement
[2]: https://dom.spec.whatwg.org/#dom-element-tagname

BUG=685012
==========

to

==========
Use the correct case converter for |localName| and |tagName|

Per spec[1], document.createElement should set |localName|
to ASCII lowercase when context object is an HTML document.

Now the AtomicString::lower() was used,
but it converts characters more than ASCII into lowercase.
So we should use AtomicString::lowerASCII() instead.

Besides, per spec[2], Element.tagName should be set to ASCII
uppercase when context object is in HTML namespace and its node
document is an HTML document.

Now we are using (Atomic)String::upper() due to lack of
ASCII uppercase support. So (Atomic)String::upperASCII() is
added to solve this issue, and AtomicString::upper() is removed
since it's not used anymore.

Tests were changed accordingly

[1]: https://dom.spec.whatwg.org/#dom-document-createelement
[2]: https://dom.spec.whatwg.org/#dom-element-tagname

BUG=685012
==========

[tkent, 2017-03-01 20:16:40]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-03-01 20:16:41]

lgtm

[commit-bot: I haz the power, 2017-03-01 20:17:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:08:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488399400672560,
"parent_rev": "494a3b618ecf62e96f14c195a0d2234b20db785c", "commit_rev":
"1337a0b763dc552f6eeadb17df348429b34a3501"}

[commit-bot: I haz the power, 2017-03-01 22:09:26]

Description was changed from

==========
Use the correct case converter for |localName| and |tagName|

Per spec[1], document.createElement should set |localName|
to ASCII lowercase when context object is an HTML document.

Now the AtomicString::lower() was used,
but it converts characters more than ASCII into lowercase.
So we should use AtomicString::lowerASCII() instead.

Besides, per spec[2], Element.tagName should be set to ASCII
uppercase when context object is in HTML namespace and its node
document is an HTML document.

Now we are using (Atomic)String::upper() due to lack of
ASCII uppercase support. So (Atomic)String::upperASCII() is
added to solve this issue, and AtomicString::upper() is removed
since it's not used anymore.

Tests were changed accordingly

[1]: https://dom.spec.whatwg.org/#dom-document-createelement
[2]: https://dom.spec.whatwg.org/#dom-element-tagname

BUG=685012
==========

to

==========
Use the correct case converter for |localName| and |tagName|

Per spec[1], document.createElement should set |localName|
to ASCII lowercase when context object is an HTML document.

Now the AtomicString::lower() was used,
but it converts characters more than ASCII into lowercase.
So we should use AtomicString::lowerASCII() instead.

Besides, per spec[2], Element.tagName should be set to ASCII
uppercase when context object is in HTML namespace and its node
document is an HTML document.

Now we are using (Atomic)String::upper() due to lack of
ASCII uppercase support. So (Atomic)String::upperASCII() is
added to solve this issue, and AtomicString::upper() is removed
since it's not used anymore.

Tests were changed accordingly

[1]: https://dom.spec.whatwg.org/#dom-document-createelement
[2]: https://dom.spec.whatwg.org/#dom-element-tagname

BUG=685012

Review-Url: https://codereview.chromium.org/2723053002
Cr-Commit-Position: refs/heads/master@{#454059}
Committed:
https://chromium.googlesource.com/chromium/src/+/1337a0b763dc552f6eeadb17df34...
==========

[commit-bot: I haz the power, 2017-03-01 22:09:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1337a0b763dc552f6eeadb17df34...