Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2723043002: Cookies disabled for gcm_network_channel. (Closed)

Created:
3 years, 9 months ago by Ramin Halavati
Modified:
3 years, 9 months ago
Reviewers:
asanka, pavely
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cookies disabled for gcm_network_channel. Following discussion in https://codereview.chromium.org/2704383002/, cookies are disabled for gcm_netwok_channel. BUG= Review-Url: https://codereview.chromium.org/2723043002 Cr-Commit-Position: refs/heads/master@{#454202} Committed: https://chromium.googlesource.com/chromium/src/+/465d378adf5c4da7daf55b6a2d7ebdcbbea71327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/invalidation/impl/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/impl/gcm_network_channel.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
Ramin Halavati
asanka@: Please review DEPS as owner of net/. pavely@: I've disabled cookies as discussed before, ...
3 years, 9 months ago (2017-03-01 08:30:15 UTC) #2
pavely
lgtm
3 years, 9 months ago (2017-03-01 15:05:03 UTC) #3
asanka
DEPS lgtm
3 years, 9 months ago (2017-03-01 17:55:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723043002/1
3 years, 9 months ago (2017-03-02 06:44:35 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 07:26:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/465d378adf5c4da7daf55b6a2d7e...

Powered by Google App Engine
This is Rietveld 408576698