Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2723023005: Make sure resent events that don't match ids are not coalesced. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
wjmaclean, tdresser
CC:
chromium-reviews, dtapuska+chromiumwatch_chromium.org, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure resent events that don't match ids are not coalesced. Resent events with different ids could get coalesced together causing a larger magnitude than originally intended. Only coalesce events that have the same id. BUG=681353 Review-Url: https://codereview.chromium.org/2723023005 Cr-Commit-Position: refs/heads/master@{#454304} Committed: https://chromium.googlesource.com/chromium/src/+/b20bd7450c4a855003e366b6c3de9bf660092b54

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M ui/events/blink/blink_event_util.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/blink/blink_event_util_unittest.cc View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dtapuska
3 years, 9 months ago (2017-03-02 17:09:56 UTC) #4
wjmaclean
lgtm
3 years, 9 months ago (2017-03-02 17:12:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723023005/1
3 years, 9 months ago (2017-03-02 17:39:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b20bd7450c4a855003e366b6c3de9bf660092b54
3 years, 9 months ago (2017-03-02 18:03:00 UTC) #12
tdresser
3 years, 9 months ago (2017-03-02 18:08:31 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698