[debugger] remove default count for top-level functions.

[debugger] remove default count for top-level functions.

If the top-level function cannot be found, we previously assumed an
invocation count of 1. This is wrong when we expect the invocation
counts to be reset for precise coverage.

TBR=jgruber@chromium.org
R=caseq@chromium.org,pfeldman@chromium.org
BUG=v8:5808
Review-Url: https://codereview.chromium.org/2723003007
Cr-Commit-Position: refs/heads/master@{#43620}
Committed: https://chromium.googlesource.com/v8/v8/+/5e0c178fe6b3110ddffde1b414b21669c2eb08ff

[Yang, 2017-03-03 07:44:14]

Here's the fix to the issue Pavel told me about yesterday. Also note that to get
incremental counts, you just need to call takePreciseCoverage again.
Starting/stopping repeatedly is not recommended since it doesn't make any
difference, except for taking a lot of time since we need to iterate the heap
everytime.

[Yang, 2017-03-03 07:44:19]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 07:44:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 08:12:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 08:12:08]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-03-06 06:29:51]

On 2017/03/03 07:44:14, Yang wrote:
> Here's the fix to the issue Pavel told me about yesterday. Also note that to
get
> incremental counts, you just need to call takePreciseCoverage again.
> Starting/stopping repeatedly is not recommended since it doesn't make any
> difference, except for taking a lot of time since we need to iterate the heap
> everytime.

ping.

[caseq, 2017-03-06 18:16:47]

lgtm

[Yang, 2017-03-06 18:20:17]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:20:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 18:20:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 18:20:26]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-v8-committers".
Note that this has nothing to do with OWNERS files.

[Yang, 2017-03-06 18:20:33]

The CQ bit was unchecked by yangguo@chromium.org

[Yang, 2017-03-06 18:21:54]

yangguo@chromium.org changed reviewers:
+ jgruber@chromium.org

[Yang, 2017-03-06 18:22:45]

On 2017/03/06 18:21:54, Yang wrote:

@caseq could you disable the blink test before I land this? Otherwise it will
just get rolled back later.

[Yang, 2017-03-06 19:03:09]

Description was changed from

==========
[debugger] remove default count for top-level functions.

If the top-level function cannot be found, we previously assumed an
invocation count of 1. This is wrong when we expect the invocation
counts to be reset for precise coverage.

R=caseq@chromium.org,pfeldman@chromium.org
BUG=v8:5808
==========

to

==========
[debugger] remove default count for top-level functions.

If the top-level function cannot be found, we previously assumed an
invocation count of 1. This is wrong when we expect the invocation
counts to be reset for precise coverage.

TBR=jgruber@chromium.org
R=caseq@chromium.org,pfeldman@chromium.org
BUG=v8:5808
==========

[Yang, 2017-03-06 19:03:20]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2017-03-06 19:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 20:49:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488827000467630,
"parent_rev": "562da356141da650d0597ddf2fb075ee997a3622", "commit_rev":
"5e0c178fe6b3110ddffde1b414b21669c2eb08ff"}

[commit-bot: I haz the power, 2017-03-06 20:49:16]

Description was changed from

==========
[debugger] remove default count for top-level functions.

If the top-level function cannot be found, we previously assumed an
invocation count of 1. This is wrong when we expect the invocation
counts to be reset for precise coverage.

TBR=jgruber@chromium.org
R=caseq@chromium.org,pfeldman@chromium.org
BUG=v8:5808
==========

to

==========
[debugger] remove default count for top-level functions.

If the top-level function cannot be found, we previously assumed an
invocation count of 1. This is wrong when we expect the invocation
counts to be reset for precise coverage.

TBR=jgruber@chromium.org
R=caseq@chromium.org,pfeldman@chromium.org
BUG=v8:5808

Review-Url: https://codereview.chromium.org/2723003007
Cr-Commit-Position: refs/heads/master@{#43620}
Committed:
https://chromium.googlesource.com/v8/v8/+/5e0c178fe6b3110ddffde1b414b21669c2e...
==========

[commit-bot: I haz the power, 2017-03-06 20:49:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5e0c178fe6b3110ddffde1b414b21669c2e...