Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2723003003: [heap] Do not delay mark-compact by doing scavenge. (Closed)

Created:
3 years, 9 months ago by ulan
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Do not delay mark-compact by doing scavenge. This hack is causing false "last-resort" garbage collections. When incremental marking is in progress and overshoots the limit, our heuristics in the allocator request finishing the mark-compact because V8 is in optimize-for-memory mode. However, the mark-compact gets replaced by scavenger which leads to retrying the allocation two times and eventually doing last resort GC (which throws away all the marking info). BUG=chromium:697119 Review-Url: https://codereview.chromium.org/2723003003 Cr-Commit-Position: refs/heads/master@{#43554} Committed: https://chromium.googlesource.com/v8/v8/+/af55a29706703121f83837d0c9020649bb9ec6ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M src/heap/heap.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ulan
PTAL. We tried to remove this in the past and had to revert (due to ...
3 years, 9 months ago (2017-03-01 18:54:46 UTC) #2
Hannes Payer (out of office)
lgtm
3 years, 9 months ago (2017-03-02 17:58:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723003003/1
3 years, 9 months ago (2017-03-02 18:00:06 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 18:27:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/af55a29706703121f83837d0c9020649bb9...

Powered by Google App Engine
This is Rietveld 408576698